[pdf-viewer] Sidebar with page thumbnails

Aperta
#13,402 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
12/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
javascript

Direzione di ricerca

The payload names no source files or tests, so start from the requirement checklist and the open questions, which need a design decision before code. Use the vcf-pdf-viewer demos (thumbnails open and thumbnails listener) as reference for the expected behaviour. Done means each checklist item works, the sidebar is keyboard and screen-reader accessible, and the PR records memory and time-to-first-thumbnail for a 500-page document.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement vaadin-pdf-viewer
Motivation

Part of #7669
Part of vaadin/platform#9815

As a user of a long document, I want small images of the pages, so that one click takes me to the page I need.

Supported by vcf-pdf-viewer add-on: thumnbails open, thumbnails listener.

Requirements
  • Toolbar button shows and hides the sidebar.
  • sidebarOpened boolean property, notify: true fires sidebar-opened-changed.
  • sidebarButtonHidden property to toggle the sidebar button visibility.
  • The sidebar shows one thumbnail for each page, at the start side of the pages.
  • The thumbnail of the current page is marked and stays in view.
  • Click, Enter or Space on a thumbnail goes to its page.
  • The thumbnails have one tab stop. Arrow keys, Home and End move between them.
  • Focus moves to the sidebar button when the sidebar closes or a new document loads.
  • Only thumbnails near the visible part of the list render. A thumbnail out of view frees its canvas and its pdf.js page data.
  • The PR records memory and the time to the first thumbnail for a document with 500 pages.
  • VoiceOver, NVDA, JAWS read each thumbnail as "Page N" and announce which one is current.
  • i18n has the texts sidebar, thumbnails and thumbnailLabel (optional - can use pageLabel)
Out of scope

Related requests to be reported in follow-up issues:

Open questions
  • Is one DOM element for each page fine, or do long documents need a virtual list?
  • Do thumbnails share the render queue of the pages, or keep their own loop at a lower priority?
  • Does Flow need an event when the user picks a thumbnail?
    • Add-on uses addThumbnailClickedListener()
Lingua principale
JavaScript
Stelle
585
Fork
105
Merge medio
12h 51m
PR unite (30g)
231

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di vaadin/web-components

Tutte le issue di vaadin/web-components

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.