[pdf-viewer] Sidebar with page thumbnails

Abierto
#13,402 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
12/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
javascript

Línea de trabajo

The payload names no source files or tests, so start from the requirement checklist and the open questions, which need a design decision before code. Use the vcf-pdf-viewer demos (thumbnails open and thumbnails listener) as reference for the expected behaviour. Done means each checklist item works, the sidebar is keyboard and screen-reader accessible, and the PR records memory and time-to-first-thumbnail for a 500-page document.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement vaadin-pdf-viewer
Motivation

Part of #7669
Part of vaadin/platform#9815

As a user of a long document, I want small images of the pages, so that one click takes me to the page I need.

Supported by vcf-pdf-viewer add-on: thumnbails open, thumbnails listener.

Requirements
  • Toolbar button shows and hides the sidebar.
  • sidebarOpened boolean property, notify: true fires sidebar-opened-changed.
  • sidebarButtonHidden property to toggle the sidebar button visibility.
  • The sidebar shows one thumbnail for each page, at the start side of the pages.
  • The thumbnail of the current page is marked and stays in view.
  • Click, Enter or Space on a thumbnail goes to its page.
  • The thumbnails have one tab stop. Arrow keys, Home and End move between them.
  • Focus moves to the sidebar button when the sidebar closes or a new document loads.
  • Only thumbnails near the visible part of the list render. A thumbnail out of view frees its canvas and its pdf.js page data.
  • The PR records memory and the time to the first thumbnail for a document with 500 pages.
  • VoiceOver, NVDA, JAWS read each thumbnail as "Page N" and announce which one is current.
  • i18n has the texts sidebar, thumbnails and thumbnailLabel (optional - can use pageLabel)
Out of scope

Related requests to be reported in follow-up issues:

Open questions
  • Is one DOM element for each page fine, or do long documents need a virtual list?
  • Do thumbnails share the render queue of the pages, or keep their own loop at a lower priority?
  • Does Flow need an event when the user picks a thumbnail?
    • Add-on uses addThumbnailClickedListener()
Lenguaje dominante
JavaScript
Estrellas
585
Forks
105
Merge medio
12 h 51 min
PR fusionados (30 d)
231

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de vaadin/web-components

Todos los issues de vaadin/web-components

Issues similares

Más issues de JavaScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.