Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Correct ledger-header fee units and document its extension member

Aperta Adatta ai principianti
  • Qualcosa non va?
#2,907 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@kaankacar ci sta già lavorando.

Dal 21/10/2026.

  • #2930 di @kaankacar — aperta

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
62/100
Tipo di issue
Documentazione
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
markdown
Ambito
documentation

Direzione di ricerca

Inizia da docs/learn/fundamentals/stellar-data-structures/ledgers.mdx: la sezione sul fee pool (intorno alla riga 110) indica erroneamente lumen. Controlla le definizioni di feePool, totalCoins, baseReserve e ext in Stellar-ledger.x, a cui rimanda l'issue. È completato quando feePool, totalCoins e baseReserve grezzi sono indicati in stroop, la conversione in XLM è spiegata e l'unione ext è descritta nell'elenco dei campi.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

raven

[!NOTE]
Automated notice: Stellar Raven filed this issue from its automated evaluation pipeline. The issue includes evidence and a public source record. Please verify the live surface before you act.

Finding

The Ledgers page says the ledger-header fee pool uses lumens rather than stroops.
The XDR field feePool holds an integer amount in stroops.
The page's ledger-header field list also omits the direct ext member.
Readers can apply the wrong conversion or construct an incomplete field list.

The adjacent totalCoins field also holds stroops, although the page describes a total number of lumens.
The page should distinguish stored units from amounts displayed in XLM.

Evidence

On 2026-10-09, the published fee-pool section explicitly specifies lumens.
The source page has the same claim.
Its field list ends at Skip list without describing ext.

The XDR definition defines feePool, totalCoins, and the direct ext union.
The union has discriminants 0 and 1.
The 1 arm holds LedgerHeaderExtensionV1.
The totalCoins comment explicitly specifies stroops and 10,000,000 stroops per XLM.

Core fee processing subtracts the integer fee from account balance.
It adds that same integer to header.current().feePool without a lumen conversion.

A public Horizon ledger read returned ledger 64853885.
Its XDR feePool was 108008397804790.
Its displayed fee_pool was 10800839.7804790 XLM.
Its XDR totalCoins was 1054439020873472865.
Its displayed total_coins was 105443902087.3472865 XLM.

Both pairs use the 10,000,000 conversion factor.
The decoded header also has ext with discriminant 0.

The source scan found this explicit denomination error only on the ledger page.
The separate lumen-supply page describes displayed Dashboard and Horizon values.
Those displayed values use XLM and do not contradict the raw XDR units.
The observed source commits do not identify when the error began.

Additional recorded evidence:

Recommendation

State that raw feePool and totalCoins use stroops.
Explain the conversion to XLM for displayed supply values.
State the raw baseReserve units with the adjacent reserve description.

Add the direct ext union to the field list.
Describe its discriminant and the versioned extension payload.
Keep transaction-set hash, close time, and upgrades under the nested StellarValue scope.
The current SCP-value paragraph already explains that nesting.

Source Record

Raven recorded this finding as sd-056 (stellar-docs, discovered 2026-10-09).

Public source record: improvements/stellar-docs/sd-056-ledger-header-fee-units-and-extension.md

Immutable source snapshot: 6f2ddd72b3a2

Resolution Handoff

When you deploy a fix, link the resolving issue or pull request to the source record.
Then notify Raven through:

https://github.com/stellar-experimental/stellar-raven/issues/new?template=upstream-improvement-ready.yml&title=%5Bupstream-ready%5D%20sd-056%3A%20

Include the finding ID and the resolving issue or pull request.
Include the deployed version or timestamp. Include the smallest live recheck.
Raven verifies the live surface before it sets the finding to fixed-upstream.
An issue closure or merged pull request does not prove the fix.
A separate reviewer repeats the live check before Raven retires the active finding.
Raven keeps a commit-pinned snapshot when one is available.

Lingua principale
MDX
Stelle
144
Fork
322
Merge medio
2g 2h
PR unite (30g)
28

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di stellar/stellar-docs

Tutte le issue di stellar/stellar-docs

Issue simili

Altre issue su Documentation

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.