Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Correct ledger-header fee units and document its extension member

Abierto Apto para principiantes
  • ¿Algo no está bien?
#2,907 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
62/100
Tipo de issue
Documentación
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
markdown
Área
documentation

Línea de trabajo

Empieza con docs/learn/fundamentals/stellar-data-structures/ledgers.mdx: la sección del fee pool (alrededor de la línea 110) dice erróneamente lumens. Revisa las definiciones de feePool, totalCoins, baseReserve y ext en Stellar-ledger.x, que enlaza el issue. Se considera terminado cuando feePool, totalCoins y baseReserve en bruto se indican en stroops, se explica la conversión a XLM y se describe la unión ext en la lista de campos.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

raven

[!NOTE]
Automated notice: Stellar Raven filed this issue from its automated evaluation pipeline. The issue includes evidence and a public source record. Please verify the live surface before you act.

Finding

The Ledgers page says the ledger-header fee pool uses lumens rather than stroops.
The XDR field feePool holds an integer amount in stroops.
The page's ledger-header field list also omits the direct ext member.
Readers can apply the wrong conversion or construct an incomplete field list.

The adjacent totalCoins field also holds stroops, although the page describes a total number of lumens.
The page should distinguish stored units from amounts displayed in XLM.

Evidence

On 2026-10-09, the published fee-pool section explicitly specifies lumens.
The source page has the same claim.
Its field list ends at Skip list without describing ext.

The XDR definition defines feePool, totalCoins, and the direct ext union.
The union has discriminants 0 and 1.
The 1 arm holds LedgerHeaderExtensionV1.
The totalCoins comment explicitly specifies stroops and 10,000,000 stroops per XLM.

Core fee processing subtracts the integer fee from account balance.
It adds that same integer to header.current().feePool without a lumen conversion.

A public Horizon ledger read returned ledger 64853885.
Its XDR feePool was 108008397804790.
Its displayed fee_pool was 10800839.7804790 XLM.
Its XDR totalCoins was 1054439020873472865.
Its displayed total_coins was 105443902087.3472865 XLM.

Both pairs use the 10,000,000 conversion factor.
The decoded header also has ext with discriminant 0.

The source scan found this explicit denomination error only on the ledger page.
The separate lumen-supply page describes displayed Dashboard and Horizon values.
Those displayed values use XLM and do not contradict the raw XDR units.
The observed source commits do not identify when the error began.

Additional recorded evidence:

Recommendation

State that raw feePool and totalCoins use stroops.
Explain the conversion to XLM for displayed supply values.
State the raw baseReserve units with the adjacent reserve description.

Add the direct ext union to the field list.
Describe its discriminant and the versioned extension payload.
Keep transaction-set hash, close time, and upgrades under the nested StellarValue scope.
The current SCP-value paragraph already explains that nesting.

Source Record

Raven recorded this finding as sd-056 (stellar-docs, discovered 2026-10-09).

Public source record: improvements/stellar-docs/sd-056-ledger-header-fee-units-and-extension.md

Immutable source snapshot: 6f2ddd72b3a2

Resolution Handoff

When you deploy a fix, link the resolving issue or pull request to the source record.
Then notify Raven through:

https://github.com/stellar-experimental/stellar-raven/issues/new?template=upstream-improvement-ready.yml&title=%5Bupstream-ready%5D%20sd-056%3A%20

Include the finding ID and the resolving issue or pull request.
Include the deployed version or timestamp. Include the smallest live recheck.
Raven verifies the live surface before it sets the finding to fixed-upstream.
An issue closure or merged pull request does not prove the fix.
A separate reviewer repeats the live check before Raven retires the active finding.
Raven keeps a commit-pinned snapshot when one is available.

Lenguaje dominante
MDX
Estrellas
144
Forks
322
Merge medio
2 d 16 h
PR fusionados (30 d)
23

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de stellar/stellar-docs

Todos los issues de stellar/stellar-docs

Issues similares

Más issues de Documentation

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.