save_zip can emit one companion twice under two spellings when the source folder folds case and the temp dir does not
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 72/100
Direzione di ricerca
Inizia in src/sil_lift/_zip.py, in save_zip, e segui _write_zip per capire come i file companion copiati e renderizzati entrano nella directory di staging. Riproduci le condizioni di una sorgente con case-folding e di un TMPDIR case-sensitive descritte nell’Issue, quindi verifica che l’archivio contenga un solo membro .lift-ranges con i byte renderizzati e nessuna variante obsoleta di maiuscole/minuscole.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Lexicon.save_zip() can produce an archive containing the same .lift-ranges twice — once stale, once current — under names differing only in case.
Preconditions
Both must hold, which is why this is not seen in ordinary use:
- The LIFT folder is on a case-folding filesystem, and its
.liftand companion disagree in case (Dict.LIFTbesideDict.lift-ranges). This is what makesRangesFile.pathcarry a spelling that is not the on-disk name —_existing_filereturns the candidate's spelling when the exact stat succeeds, and on a folding filesystem it succeeds for a case variant. TMPDIRis on a case-sensitive filesystem. On macOS that is a case-sensitive APFS volume; on Linux, a LIFT folder on ciopfs / exfat / casefold-enabled ext4 with/tmpon ext4.
Normally these are the same filesystem — the divergence needs folding, and staging happens on the same machine — so the second write lands on the first file and nothing goes wrong.
Mechanism
save_zip (src/sil_lift/_zip.py) stages into a TemporaryDirectory, copies the whole source package in, then overwrites the rendered files by name:
shutil.copytree(source_root, content, dirs_exist_ok=True) # brings in Dict.lift-ranges
...
name = ranges_file.path.name if ranges_file.path is not None else Path(key).name
(content / name).write_bytes(render_ranges_document(ranges_file)) # writes Dict.LIFT-ranges
_write_zip then walks the staging directory, so members come from the filesystem rather than from the names. Where staging folds case, the second write overwrites the copied file and leaves its directory entry alone: one file, one member, correct bytes. Where staging does not fold, it creates a second file, and the archive gets both — the stale copytree'd bytes under the on-disk spelling and the rendered bytes under the href's spelling.
On read-back the duplicate is not rejected: _select_lift_member only guards against multiple .lift members, and two case-variant .lift-ranges are resolved the way any such folder is — one wins.
Fix options
- Narrow, in
save_zip: before writing, look for a file already in staging whose name folds ontonameand write to that spelling instead. Keeps the change local to packaging. - At the root, in
_resolve_ranges: handRangesFile.loadthe canonical path soRangesFile.pathalways matches what is on disk. Tempting one-liner, but the canonical path is absolute and symlink-collapsed, so it changes a public attribute's value and whatRangesFile.save()targets for every caller — a much wider blast radius than the defect.
The first looks right; the second is worth ruling out deliberately rather than by omission.
Notes
Pre-existing: _resolve_ranges passed the candidate's spelling to RangesFile.load before #19 as well. Split out of review discussion on #19, which kept its scope to companion resolution.
- Lingua principale
- Python
- Stelle
- 1
- Fork
- 0
- Merge medio
- 11g 3h
- PR unite (30g)
- 6
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di sillsdev/python-sil-lift
-
enhancement
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
sillsdev/python-sil-lift#15 ·
-
bug
Difficoltà 5/5 Più di una settimana Idoneità per principianti 35/100
sillsdev/python-sil-lift#45 ·
-
Media hrefs resolve case-sensitively: Windows-authored folders get false missing-media on Linux Apertabug
Difficoltà 5/5 Più di una settimana Idoneità per principianti 38/100
sillsdev/python-sil-lift#34 · 1 commento · 1 assegnatario ·
-
bug
Difficoltà 3/5 1-2 giorni Idoneità per principianti 72/100
sillsdev/python-sil-lift#33 ·
-
Difficoltà 5/5 Più di una settimana Idoneità per principianti 25/100
sillsdev/python-sil-lift#30 ·
Tutte le issue di sillsdev/python-sil-lift
Issue simili
-
bug confirmed issue
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
open-webui/open-webui#30750 · 1 commento ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
-
enhancement
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
OpenwaterHealth/openmotion-bloodflow-app#604 · 1 commento ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
-
good first issue
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 90/100