HermitCrab analysis: store folded equivalent analyses as differences, not whole Words (per-word memory)

Aperta
  • Qualcosa non va?
#640 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
csharp
Ambito
backend, performance

Direzione di ricerca

Read AnalysisStratumRule.cs around lines 162–171 and Word.cs around lines 80–94 and 467–513 to trace how alternatives are stored and expanded. The issue says to first measure how many bytes folded alternatives hold in C# on a heavy word; the proposed storage change is recorded for later and is not scheduled. Done means alternatives can be rebuilt from their differences while synthesis results remain exact.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Hermit Crab performance

HermitCrab stores each folded equivalent analysis as a whole Word. When two analyses have the same merge key, AnalysisStratumRule.Apply does canonicalWord.Alternatives.Add(mruleOutWord) (AnalysisStratumRule.cs:167-171), keeping the full word: its own Shape, two feature structures, _allomorphs dictionary, _mruleApps list and non-head list, all copied in the Word(Word) constructor (Word.cs:80-94). What actually differs from the canonical is small: the morphological rule trail, the allomorph trail and the syntactic feature structure.

Recorded for later, not scheduled. Related to #593 and #595 (sharing the shape and feature structures inside each word); this one is about not keeping a full word per alternative at all.

No C# memory measurement exists for this mechanism. The numbers are PanGloss ones; the C# structure is the same (Word.Alternatives, Word.cs:467) and C# already rebuilds alternatives from a difference on demand in Word.ExpandAlternatives (Word.cs:472-513), which only applies trail and feature-structure changes on top of the source.

Idea: store a folded alternative as its differences (rule trail, allomorph trail, syntactic feature structure) and rebuild the Word when synthesis expands it. Keep the word whole whenever any other field differs, so results stay exact.

Reference implementation: sillsdev/PanGloss#250 (stacked on #249). Results are identical to before (status, signature, work steps on four grammars); the change is storage only.

Evidence (PanGloss, Rust)

Word mindeshi, Mbugwe, peak resident set, one thread. #250 on top of shape and feature-structure sharing: 50M cap 82 to 59 MB, 200M cap 389 to 267 MB, 1G cap 1,408 to 774 MB. At a 200M cap the search held 94,010 canonical words and 285,384 alternatives, three quarters of all words. An alternative was a 336-byte inline Word plus about 256 bytes of heap for trails and a map; in that search the alternatives differed from their canonical only by trail and syntactic features. Instructions did not regress (Swahili -3.48%, Cebuano -2.71%, Amharic +0.13%).

Notes and risks
  • C# alternatives are created from mruleOutWord, which is itself a clone-derived word, so #593 shrinks them but does not remove the per-alternative object, dictionary and lists.
  • ExpandAlternatives reads the canonical at expansion time, and the canonical's syntactic feature structure is widened by later arrivals, so a delta must be rebuilt from the canonical at expansion, not fold, time.
  • The Source chain (AnalysisStratumRule.cs:162) keeps earlier strata's words reachable from alternatives; a delta form must not break ExpandAlternatives.
  • Related: #512 (cull candidates at emission) attacks the same retained set from the other side.

Next: recorded for later, not scheduled. Measure how many bytes folded alternatives hold in C# on a heavy word before building anything.

Lingua principale
C#
Stelle
29
Fork
16
Merge medio
4g 11h
PR unite (30g)
14

Preparare l'ambiente

  • Nessun Dockerfile né file Docker Compose
  • Ha un modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di sillsdev/machine

Tutte le issue di sillsdev/machine

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.