HermitCrab analysis: store folded equivalent analyses as differences, not whole Words (per-word memory)

Ouverte
  • Quelque chose ne va pas ?
#640 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
5/5
Temps estimé
Plus d'une semaine
Accessibilité débutants
35/100
Type d'issue
Fonctionnalité
Clarté
Clairement spécifiée
Activité
Active
Stack technique
csharp
Domaine
backend, performance

Piste de recherche

Read AnalysisStratumRule.cs around lines 162–171 and Word.cs around lines 80–94 and 467–513 to trace how alternatives are stored and expanded. The issue says to first measure how many bytes folded alternatives hold in C# on a heavy word; the proposed storage change is recorded for later and is not scheduled. Done means alternatives can be rebuilt from their differences while synthesis results remain exact.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Hermit Crab performance

HermitCrab stores each folded equivalent analysis as a whole Word. When two analyses have the same merge key, AnalysisStratumRule.Apply does canonicalWord.Alternatives.Add(mruleOutWord) (AnalysisStratumRule.cs:167-171), keeping the full word: its own Shape, two feature structures, _allomorphs dictionary, _mruleApps list and non-head list, all copied in the Word(Word) constructor (Word.cs:80-94). What actually differs from the canonical is small: the morphological rule trail, the allomorph trail and the syntactic feature structure.

Recorded for later, not scheduled. Related to #593 and #595 (sharing the shape and feature structures inside each word); this one is about not keeping a full word per alternative at all.

No C# memory measurement exists for this mechanism. The numbers are PanGloss ones; the C# structure is the same (Word.Alternatives, Word.cs:467) and C# already rebuilds alternatives from a difference on demand in Word.ExpandAlternatives (Word.cs:472-513), which only applies trail and feature-structure changes on top of the source.

Idea: store a folded alternative as its differences (rule trail, allomorph trail, syntactic feature structure) and rebuild the Word when synthesis expands it. Keep the word whole whenever any other field differs, so results stay exact.

Reference implementation: sillsdev/PanGloss#250 (stacked on #249). Results are identical to before (status, signature, work steps on four grammars); the change is storage only.

Evidence (PanGloss, Rust)

Word mindeshi, Mbugwe, peak resident set, one thread. #250 on top of shape and feature-structure sharing: 50M cap 82 to 59 MB, 200M cap 389 to 267 MB, 1G cap 1,408 to 774 MB. At a 200M cap the search held 94,010 canonical words and 285,384 alternatives, three quarters of all words. An alternative was a 336-byte inline Word plus about 256 bytes of heap for trails and a map; in that search the alternatives differed from their canonical only by trail and syntactic features. Instructions did not regress (Swahili -3.48%, Cebuano -2.71%, Amharic +0.13%).

Notes and risks
  • C# alternatives are created from mruleOutWord, which is itself a clone-derived word, so #593 shrinks them but does not remove the per-alternative object, dictionary and lists.
  • ExpandAlternatives reads the canonical at expansion time, and the canonical's syntactic feature structure is widened by later arrivals, so a delta must be rebuilt from the canonical at expansion, not fold, time.
  • The Source chain (AnalysisStratumRule.cs:162) keeps earlier strata's words reachable from alternatives; a delta form must not break ExpandAlternatives.
  • Related: #512 (cull candidates at emission) attacks the same retained set from the other side.

Next: recorded for later, not scheduled. Measure how many bytes folded alternatives hold in C# on a heavy word before building anything.

Langage dominant
C#
Étoiles
29
Forks
16
Merge moyen
4 j 11 h
PR mergées (30 j)
14

Préparer son environnement

  • Aucun Dockerfile ni fichier Docker Compose
  • Propose un modèle de pull request
  • Aucun guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de sillsdev/machine

Toutes les issues de sillsdev/machine

Issues similaires

Plus d'issues C#

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.