fix: ReplaceStore swaps the symlink, not the store, when the live store directory is a symlink

Aperta
#364 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
55/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
go
Ambito
backend

Direzione di ricerca

Read internal/graphstore/locks.go around ReplaceStore and internal/indexer/fullindex.go at the production call site; compare how #339 resolves store paths for lock files. The issue leaves the path-resolution approach open, and reproduction still needs confirmation. Done means a full index through a symlink updates the target store and keeps the symlink, or returns a clear error.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area:indexer bug needs-triage
What happens

Not reproduced yet. This comes from reading the code while fixing #339.

ReplaceStore(staging, live) in internal/graphstore/locks.go works on live as the caller passes it. It takes the swap lock, then calls os.Lstat(live) at line 118 of commit 990b6499.

If live is a symlink to the store directory, Lstat reports the link itself. The code then locks live at line 126 and calls exchangeDirs(staging, live) at line 131, which wraps fsatomic.ExchangeDirs. The exchange swaps the link's directory entry with staging.

The link name then holds the new index, and staging holds the symlink. The real store behind the link keeps the old index, and the link is gone.

The only production caller is run in internal/indexer/fullindex.go at line 184. codegraph init runs that full index. The same function exists on main with the same shape.

What you expected instead

One store has one identity, whatever name opens it. A full index through a symlinked store path must replace the store the link points to and keep the link. Otherwise, it must refuse with a clear error.

Whether ReplaceStore resolves live through resolveStorePath, as the #339 fix does for the lock files, is an open question.

Steps to reproduce
  1. Create a store at real/store with a full index.
  2. Run ln -s real/store link.
  3. Run a full index with the store path set to link. The flag or setting for the store path is not confirmed yet.
  4. Run ls -l link, then see whether real/store holds the new index.
Version

Built from source at commit 990b6499 on branch fix/339-swap-lock-realpath. The same function exists on main.

Platform

macOS, Darwin 27.2.0

How did you install it?

Built from source

Languages in the affected repository

Not applicable. The bug is in store path handling, not in extraction.

Related

#339 moves the swap and writer lock files beside the resolved store path. #324 covers letter case, and #286 covers path spellings for serve.

Before submitting
  • I searched existing issues and this is not a duplicate
  • I checked the capability matrix and this is not a documented limitation
  • This is not a security vulnerability

🤖 Generated with Claude Code

https://claude.ai/code/session_0167DcyrN4PrZewitbjYLc9L

Lingua principale
Go
Stelle
0
Fork
0
Merge medio
7h 42m
PR unite (30g)
111

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di seanb4t/codegraph-go

Tutte le issue di seanb4t/codegraph-go

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.