fix: ReplaceStore swaps the symlink, not the store, when the live store directory is a symlink
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 55/100
Línea de trabajo
Read internal/graphstore/locks.go around ReplaceStore and internal/indexer/fullindex.go at the production call site; compare how #339 resolves store paths for lock files. The issue leaves the path-resolution approach open, and reproduction still needs confirmation. Done means a full index through a symlink updates the target store and keeps the symlink, or returns a clear error.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
What happens
Not reproduced yet. This comes from reading the code while fixing #339.
ReplaceStore(staging, live) in internal/graphstore/locks.go works on live as the caller passes it. It takes the swap lock, then calls os.Lstat(live) at line 118 of commit 990b6499.
If live is a symlink to the store directory, Lstat reports the link itself. The code then locks live at line 126 and calls exchangeDirs(staging, live) at line 131, which wraps fsatomic.ExchangeDirs. The exchange swaps the link's directory entry with staging.
The link name then holds the new index, and staging holds the symlink. The real store behind the link keeps the old index, and the link is gone.
The only production caller is run in internal/indexer/fullindex.go at line 184. codegraph init runs that full index. The same function exists on main with the same shape.
What you expected instead
One store has one identity, whatever name opens it. A full index through a symlinked store path must replace the store the link points to and keep the link. Otherwise, it must refuse with a clear error.
Whether ReplaceStore resolves live through resolveStorePath, as the #339 fix does for the lock files, is an open question.
Steps to reproduce
- Create a store at
real/storewith a full index. - Run
ln -s real/store link. - Run a full index with the store path set to
link. The flag or setting for the store path is not confirmed yet. - Run
ls -l link, then see whetherreal/storeholds the new index.
Version
Built from source at commit 990b6499 on branch fix/339-swap-lock-realpath. The same function exists on main.
Platform
macOS, Darwin 27.2.0
How did you install it?
Built from source
Languages in the affected repository
Not applicable. The bug is in store path handling, not in extraction.
Related
#339 moves the swap and writer lock files beside the resolved store path. #324 covers letter case, and #286 covers path spellings for serve.
Before submitting
- I searched existing issues and this is not a duplicate
- I checked the capability matrix and this is not a documented limitation
- This is not a security vulnerability
🤖 Generated with Claude Code
- Lenguaje dominante
- Go
- Estrellas
- 0
- Forks
- 0
- Merge medio
- 7 h 42 min
- PR fusionados (30 d)
- 111
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de seanb4t/codegraph-go
-
chore needs-triage
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100
seanb4t/codegraph-go#380 ·
Los mantenedores suelen responder en 1 día
-
chore needs-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
seanb4t/codegraph-go#379 ·
Los mantenedores suelen responder en 1 día
-
area:query chore needs-triage spec-needed
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
seanb4t/codegraph-go#377 ·
Los mantenedores suelen responder en 1 día
-
chore needs-triage
Dificultad 1/5 1-3 horas Aptitud para principiantes 84/100
seanb4t/codegraph-go#362 ·
Los mantenedores suelen responder en 1 día
-
area:query bug needs-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 80/100
seanb4t/codegraph-go#355 ·
Los mantenedores suelen responder en 1 día
Todos los issues de seanb4t/codegraph-go
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 77/100
Los mantenedores suelen responder en 1 día
-
automated documentation maintenance
Dificultad 1/5 1-3 horas Aptitud para principiantes 75/100
github/gh-aw-mcpg#16717 ·
Los mantenedores suelen responder en 1 día
-
Docs: Recording rules pages don't say what happens to a recorded metric when its rule is deletedAbiertointernal
Dificultad 1/5 1-3 horas Aptitud para principiantes 84/100
Los mantenedores suelen responder en 1 día
-
enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
jesseduffield/lazygit#6229 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
prometheus/prometheus#20482 ·
Los mantenedores suelen responder en 2 días