feat(ui): show the definition of each row for a name with several definitions

Aperta
#322 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
35/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
go
Ambito
api, frontend

Direzione di ricerca

Start in internal/uiserver/handlers.go, where the UI calls Callers, Callees and Impact, and in the uiv1.Location protobuf message, which needs a definition-label field. Read decision D8 in the archived change and the same-name-query-targets change (#318), which this depends on, before touching the response shapes. Done when each row carries its definition label, the three responses carry the definition list, the three requests accept a file input matching --file, and the Svelte views display both, with single-definition names unchanged.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area:ui enhancement priority:low
What exists today?

The graph UI calls the engine functions Callers, Callees and Impact through internal/uiserver/handlers.go. Each row is a uiv1.Location with a name, a kind, a file and a line.

How does it behave now?

The change same-name-query-targets (#318) makes those functions answer for every definition of a name. The CLI and the MCP tools then name the definition of each row and list the definitions. The UI gets the same rows, but uiv1.Location has no field for the definition, and the responses have no list of definitions. A UI row for a name with several definitions shows its own file and line. It does not show which definition it belongs to.

The UI requests also have no file input, so the UI has no way to select the definitions in one file.

How should it behave?
  • uiv1.Location carries the definition label of the row.
  • The callers, callees and impact responses carry the list of definitions.
  • The three requests accept a file, with the meaning of --file.
  • The Svelte views show the label and the list.

The design of the archived change records this cut in its decision D8.

What kind of improvement?

Other

Would this change existing behavior?

The protobuf messages gain fields, which is additive. The views show more text for a name with several definitions. A name with one definition looks the same.

Before submitting
  • I searched existing issues and this is not a duplicate
  • I checked that the current behavior is not a deliberate decision in openspec/specs/
Lingua principale
Go
Stelle
0
Fork
0
Merge medio
7h 42m
PR unite (30g)
111

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di seanb4t/codegraph-go

Tutte le issue di seanb4t/codegraph-go

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.