feat(ui): show the definition of each row for a name with several definitions

Abierto
#322 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
35/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
go
Área
api, frontend

Línea de trabajo

Start in internal/uiserver/handlers.go, where the UI calls Callers, Callees and Impact, and in the uiv1.Location protobuf message, which needs a definition-label field. Read decision D8 in the archived change and the same-name-query-targets change (#318), which this depends on, before touching the response shapes. Done when each row carries its definition label, the three responses carry the definition list, the three requests accept a file input matching --file, and the Svelte views display both, with single-definition names unchanged.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:ui enhancement priority:low
What exists today?

The graph UI calls the engine functions Callers, Callees and Impact through internal/uiserver/handlers.go. Each row is a uiv1.Location with a name, a kind, a file and a line.

How does it behave now?

The change same-name-query-targets (#318) makes those functions answer for every definition of a name. The CLI and the MCP tools then name the definition of each row and list the definitions. The UI gets the same rows, but uiv1.Location has no field for the definition, and the responses have no list of definitions. A UI row for a name with several definitions shows its own file and line. It does not show which definition it belongs to.

The UI requests also have no file input, so the UI has no way to select the definitions in one file.

How should it behave?
  • uiv1.Location carries the definition label of the row.
  • The callers, callees and impact responses carry the list of definitions.
  • The three requests accept a file, with the meaning of --file.
  • The Svelte views show the label and the list.

The design of the archived change records this cut in its decision D8.

What kind of improvement?

Other

Would this change existing behavior?

The protobuf messages gain fields, which is additive. The views show more text for a name with several definitions. A name with one definition looks the same.

Before submitting
  • I searched existing issues and this is not a duplicate
  • I checked that the current behavior is not a deliberate decision in openspec/specs/
Lenguaje dominante
Go
Estrellas
0
Forks
0
Merge medio
7 h 42 min
PR fusionados (30 d)
111

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de seanb4t/codegraph-go

Todos los issues de seanb4t/codegraph-go

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.