Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Y26-127 - As a manager in short read in charge of billing, I want the billing report to correctly handle Bioscan samples.

Aperta
  • Qualcosa non va?
#54 3 commenti 1 reazione 1 assegnatario Vedi su GitHub

@dn10-sanger ci sta già lavorando.

Dal 9/4/2026.

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

enhancement good first issue Research

User Story
As a manager in Short Read in charge of billing, I want the billing report to correctly handle BioScan samples, so that lane proportions and totals are accurate when ToL begin using the billing report.

Acceptance Criteria
TBD pending stakeholder input

Who the primary contacts are for this work
Tom W
Ivy T
Laura H
Rich R
Dikshita N

Context
The billing report joins stock_resource to retrieve stock plate barcodes. For Bioscan samples, a single sample can be associated with more than one stock plate (e.g. both a LILYS plate and a Lysate plate are registered as stock plates in stock_resource)- see https://github.com/sanger/sequencescape/issues/4706 for where it was implemented. This causes the sample to appear multiple times in the sample_lanes CTE, which inflates the COUNT(*) used to calculate lane proportions resulting in incorrect total values for Bioscan runs.

This is a known limitation and was flagged during development of https://github.com/sanger/sample-tracking/issues/51. ToL are not currently using the billing report so this is not urgent, but it must be resolved before they do.

Suggested two possible approaches

  1. Show one row per sample and choose the stock plate barcode most useful for billing.
  2. Show one row per sample and concatenate multiple stock plate barcodes into one field.

Known Bioscan pipeline routes:

  1. Extraction performed in SeqOps :
    Service user provides the LILYS-96 plate to SeqOps, and SeqOps perform the extraction and produce the Lysate
    plate -> two stock plates expected since https://github.com/sanger/sequencescape/issues/4706. Only one (LILYS) expected before that, unless data was back-filled.
  2. Extraction performed in programmes :
    Faculty perform the extraction themselves and provide the Lysate plate to SeqOps - > one stock plate expected (Lysate)

Research Task

  1. Inspect Bioscan sample data in stock_resource to understand how often samples have one vs multiple stock plates.
  2. Review examples covering the two known pipeline routes.
  3. Confirm with stakeholders whether to pick one stock plate or concatenate multiple barcodes.
  4. Use findings to define the implementation approach and write acceptance criteria for the fix.

Reference
sanger/ sample-tracking https://github.com/sanger/sample-tracking/issues/51

Lingua principale
Python
Stelle
0
Fork
0
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di sanger/sample-tracking

Tutte le issue di sanger/sample-tracking

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.