bug: timeline span `seq` names a different event per span kind, and all five are undocumented

Aperta
#1,859 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
35/100
Tipo di issue
Refactoring
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
go
Ambito
api, backend

Direzione di ricerca

Start in core/session/timeline/timeline.go, where the five span structs declare a bare Seq field, then check agents.go (around lines 125-202) and hosts.go (lines 54 and 63) to confirm which event each one sets. The issue leaves open whether to rename the field with a deprecation period or only add doc comments, so settle that with a maintainer first. Done means each span's seq meaning is stated in code and in docs/session-api.md.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug documentation

Summary

GET /v1/sessions/{id}/timeline returns five span kinds, each with a seq. Four name the request event; one names the response. All five fields are undocumented, in a package where every other field carries a paragraph.

A consumer joining timeline spans to event data on seq therefore matches nothing for four of the five kinds — and gets no error, just an empty result, which is the failure mode that costs the most time to diagnose.

The actual mapping

On main (core/session/timeline/):

Span Declared Set at seq is the
Turn timeline.go:88 agents.go:176 — Seq: c.req.Seq request event
Tool timeline.go:105 agents.go:202 — Seq: c.resp.Seq response event
Job timeline.go:118 agents.go:125 — Seq: c.req.Seq request event
Return timeline.go:126 agents.go:161 — Seq: c.req.Seq request event
Host timeline.go:138 hosts.go:54, :63 — Seq: e.Seq the event it came from

Every one of those five declarations is a bare Seq uint64 \json:"seq"`with no comment. Compare the fields around them —Resent, Error, Model, ToolUseID` all have one, several of them a full paragraph.

How it bites

Token counts live on the response event (inference.inputTokens and friends). So the natural query — "show me each model call's latency beside its tokens" — joins turns[].seq to a response event and silently returns nothing:

# Returns a header and zero rows. No error.
jq -n --slurpfile tl tl.json --slurpfile ev ev.json '
  ($ev[0].events | map(select(.phase=="response")) | INDEX(.seq|tostring)) as $byseq
  | $tl[0].turns[] | select($byseq[(.seq|tostring)] != null)'

Measured on a 2,911-event session: 0 of 509 turns[].seq values in the paged range matched a response event. Switching to tools[].seq matched 458 of 592 immediately.

It cost two people on #1854 — once writing the query, once a reviewer who went to core/sessionapi/timeline.go (a real, different file) chasing the bare timeline.go:88 citation and found cache internals.

Proposed fix

Rename, do not just document. The names are the trap: identical field name, identical type, different referent, and nothing at the call site to warn you.

type Turn struct {
    // RequestSeq is the seq of the REQUEST event this turn began at. Token counts and
    // the status live on the matching RESPONSE event — pair by requestId, not by this.
    RequestSeq uint64 `json:"requestSeq"`
}

type Tool struct {
    // ResponseSeq is the seq of the RESPONSE event that asked for this tool, so it joins
    // directly to that event's inference fields.
    ResponseSeq uint64 `json:"responseSeq"`
}

That is a wire change, so it needs the usual skew handling: emit both keys for a release (seq plus the new name), with seq documented as deprecated, then drop it. agentop is the only in-tree consumer.

If a rename is too invasive, the minimum is a doc comment on each of the five saying which event it names, plus the mapping table above in docs/session-api.md. That is already done on the docs side in #1854, but the struct fields themselves remain bare — and a consumer reads the struct, not someone else's spec.

Also worth fixing alongside

/timeline reads up to 50,000 events; GET /v1/sessions/{id} caps ?limit at 2,000. Both numbers are documented, 70 lines apart in session-api.md, and never related to each other. On the same 2,911-event session a single-page join covers only the newest 2,000 events, so 134 of 592 tool spans have no matching event row unless the consumer pages with ?before=. #1854 documents this; the asymmetry itself may still be worth closing.

Scope note

Found while writing the queries in #1854's §9.3, against one developer's laptop archive (66 sessions, 29,606 events). The mapping generalises — it follows the code, not this traffic. The match counts above are from one 2,911-event session.

Refs #1854, #1810

Lingua principale
Go
Stelle
26
Fork
46
Merge medio
9h 55m
PR unite (30g)
257

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di rossoctl/cortex

Tutte le issue di rossoctl/cortex

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.