bug: The JWT bypass matches a cleaned path but forwards the raw path, so /mcp/../healthz skips validation

Aperta
#1,884 0 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@evaline-ju ci sta già lavorando.

Dal 16/11/2026.

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

bug

Problem

The inbound JWT bypass compares a cleaned path, but the app behind the sidecar gets the raw path. A request with .. segments can match a bypass pattern and then reach a protected handler with no token.

/healthz and /.well-known/* are in bypass.DefaultPatterns (core/bypass/matcher.go:12), so the default config has this problem.

Reproduction (main at 676557d35)

  1. Cortex side, Go test:
    • bypass.NewMatcher(bypass.DefaultPatterns).Match("/mcp/../healthz") returns true.
    • A reverseproxy.NewServer in front of a test backend gets the raw request POST /mcp/../healthz HTTP/1.1. The backend sees RequestURI = "/mcp/../healthz", and the status is 200.
  2. App side: a FastAPI 0.136 app on uvicorn 0.35 with @app.post("/mcp/{rest:path}"). curl --path-as-is -X POST http://127.0.0.1:<port>/mcp/../healthz returns {"handler":"protected-mcp","rest":"../healthz"}.

Together: the request skips JWT validation as /healthz, and the app runs the protected /mcp handler.

Cause

  • core/bypass/matcher.go:46: Match runs path.Clean(requestPath) before it matches. The repo's own test asserts that Match("/foo/../healthz") is true.
  • core/plugins/jwtvalidation/plugin.go:393-398 passes pctx.Path to the bypass check. The reverse proxy sets pctx.Path from the decoded r.URL.Path (core/listener/reverseproxy/server.go:337). So /mcp/..%2Fhealthz also decodes to /mcp/../healthz.
  • The reverse proxy forwards the original path. It has no ServeMux that cleans or redirects the path.

Fix

In Match, return false when path.Clean(p) != p (allow one trailing slash if needed). Then a non-canonical path never bypasses validation. Also match on the escaped path, not the decoded one. Add a test for /mcp/../healthz and /mcp/..%2Fhealthz through jwt-validation.

Impact if not fixed

In sidecar deployments, a caller with no token can reach protected inbound routes on apps that do not normalize .. segments. The laptop install does not use inbound JWT validation. Not checked: frameworks other than FastAPI (Express, Spring). The envoy-sidecar path (ext_proc) was not tested.

Lingua principale
Go
Stelle
26
Fork
46
Merge medio
9h 55m
PR unite (30g)
257

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di rossoctl/cortex

Tutte le issue di rossoctl/cortex

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.