Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

[RF] HS3 export: constraints serialized as product_dist factors with global observables as const parameters

Aperta
  • Qualcosa non va?
#22,597 4 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@guitargeek ci sta già lavorando.

Dal 13/6/2026.

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

in:RooFit new feature

Context: we are implementing an independent HS3 consumer (pyhs3) and validating it against quickFit NLL values on an ATLAS diHiggs (bbγγ) workspace exported via RooFit's HS3 JSON export. This is feedback on the export pattern for constraint terms — not a blocker (we reproduce RooFit's behavior), but it required reverse-engineering RooFit internals rather than reading the file.

cc @cburgard @Phmonski

What the export produces (per channel, ×14 channels, ×148 constraints)

// distribution block
{ "name": "constr__THEO_BR_Hbb", "type": "gaussian_dist",
  "x": "THEO_BR_Hbb",            // nuisance parameter
  "mean": "RNDM__THEO_BR_Hbb",   // global observable
  "sigma": 1.0 }

// channel pdf
{ "name": "_model_Run2HM_1", "type": "product_dist",
  "factors": ["_modelSB_Run2HM_1", "constr__THEO_BR_Hbb", "..."] }

// parameter_points
{ "name": "RNDM__THEO_BR_Hbb", "value": 0.0, "const": true }

Consequences for a non-RooFit consumer

  1. Constraint-ness is not marked. Nothing in the file distinguishes a constraint factor from a shape factor except naming conventions (constr__, RNDM__) and graph structure (the factor does not depend on the dataset's variables). We infer it structurally, but the likelihood counting semantics this forces are currently unspecified in HS3 — a factor independent of the data must enter the likelihood once per likelihood, not once per event nor once per channel (RooProdPdf's behavior). We have filed a matching HS3-spec issue: hep-statistics-serialization-standard/hep-statistics-serialization-standard#90. Flagging here because the export pattern is what triggers the ambiguity.

  2. Global observables become parameters. RNDM__* are observations of auxiliary measurements; serializing them as const: true parameter points erases the distinction RooFit's ModelConfig maintains (GlobalObservables). A consumer cannot reconstruct which constants are global observables (e.g. to randomize them for toys) except by the RNDM__ prefix convention. The misc.ROOT_internal.ModelConfigs block only records pdf/mc names, not the global-observable set.

  3. HS3 already has a cleaner encoding. Section 2.4 of the spec allows a constraint to be its own (distribution, datum) likelihood entry with the auxiliary measurement as inline numeric data:

    "likelihoods": [{
  "distributions": ["...", "constr__THEO_BR_Hbb"],
  "data":          ["...", 0.0]
}]

    That representation is unambiguous (counting is automatic), keeps data as data, and removes the need for RNDM__* const parameters. Could the export move constraints there — or at least record the global-observables list in a standard location?

Minor observation, likely from the original workspace construction rather than the export: the constraint Gaussians have the NP as x and the global observable as mean (pdf over the NP), whereas the auxiliary-measurement reading is a pdf over the global observable with the NP as mean. Numerically identical for a symmetric Gaussian, but the declared random variable matters for normalization/toy semantics in a strict reading.

Lingua principale
C++
Stelle
3.3k
Fork
1.6k
Merge medio
2g 17h
PR unite (30g)
188

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di root-project/root

Tutte le issue di root-project/root

Issue simili

Altre issue su C++

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.