Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

[RF] HS3 export: constraints serialized as product_dist factors with global observables as const parameters

Abierto
  • ¿Algo no está bien?
#22,597 4 comentarios 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 1 día

@guitargeek ya está trabajando en esto.

Desde el 13/6/2026.

Evaluación

Este issue todavía no se ha evaluado.

Descripción

in:RooFit new feature

Context: we are implementing an independent HS3 consumer (pyhs3) and validating it against quickFit NLL values on an ATLAS diHiggs (bbγγ) workspace exported via RooFit's HS3 JSON export. This is feedback on the export pattern for constraint terms — not a blocker (we reproduce RooFit's behavior), but it required reverse-engineering RooFit internals rather than reading the file.

cc @cburgard @Phmonski

What the export produces (per channel, ×14 channels, ×148 constraints)

// distribution block
{ "name": "constr__THEO_BR_Hbb", "type": "gaussian_dist",
  "x": "THEO_BR_Hbb",            // nuisance parameter
  "mean": "RNDM__THEO_BR_Hbb",   // global observable
  "sigma": 1.0 }

// channel pdf
{ "name": "_model_Run2HM_1", "type": "product_dist",
  "factors": ["_modelSB_Run2HM_1", "constr__THEO_BR_Hbb", "..."] }

// parameter_points
{ "name": "RNDM__THEO_BR_Hbb", "value": 0.0, "const": true }

Consequences for a non-RooFit consumer

  1. Constraint-ness is not marked. Nothing in the file distinguishes a constraint factor from a shape factor except naming conventions (constr__, RNDM__) and graph structure (the factor does not depend on the dataset's variables). We infer it structurally, but the likelihood counting semantics this forces are currently unspecified in HS3 — a factor independent of the data must enter the likelihood once per likelihood, not once per event nor once per channel (RooProdPdf's behavior). We have filed a matching HS3-spec issue: hep-statistics-serialization-standard/hep-statistics-serialization-standard#90. Flagging here because the export pattern is what triggers the ambiguity.

  2. Global observables become parameters. RNDM__* are observations of auxiliary measurements; serializing them as const: true parameter points erases the distinction RooFit's ModelConfig maintains (GlobalObservables). A consumer cannot reconstruct which constants are global observables (e.g. to randomize them for toys) except by the RNDM__ prefix convention. The misc.ROOT_internal.ModelConfigs block only records pdf/mc names, not the global-observable set.

  3. HS3 already has a cleaner encoding. Section 2.4 of the spec allows a constraint to be its own (distribution, datum) likelihood entry with the auxiliary measurement as inline numeric data:

    "likelihoods": [{
  "distributions": ["...", "constr__THEO_BR_Hbb"],
  "data":          ["...", 0.0]
}]

    That representation is unambiguous (counting is automatic), keeps data as data, and removes the need for RNDM__* const parameters. Could the export move constraints there — or at least record the global-observables list in a standard location?

Minor observation, likely from the original workspace construction rather than the export: the constraint Gaussians have the NP as x and the global observable as mean (pdf over the NP), whereas the auxiliary-measurement reading is a pdf over the global observable with the NP as mean. Numerically identical for a symmetric Gaussian, but the declared random variable matters for normalization/toy semantics in a strict reading.

Lenguaje dominante
C++
Estrellas
3.3k
Forks
1.6k
Merge medio
2 d 17 h
PR fusionados (30 d)
188

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de root-project/root

Todos los issues de root-project/root

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.