A slot whose date changes keeps its old place, so a date-ordered list falls out of order

Aperta
  • Qualcosa non va?
#750 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
75/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
backend

Direzione di ricerca

Start by reading updateSlot in src/services/slots.ts and SLOT_DISPLAY_ORDER in src/services/locks.ts to see how slots are ordered. Implement conditional renumbering via writeSlotOrder as reorderSlots does, then run src/services/slots.db.test.ts and pnpm checks. Done when date-ordered signups auto-move the edited slot and hand-ordered ones stay put.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement pipeline:proposed pipeline:ux

Needs your OK: this changes the order slots appear in, for organizers and participants, after a slot's date changes. Swap pipeline:proposed for pipeline:ready to have it built.

What happens

When an organizer corrects a slot's date, the slot keeps its old place in the list. On a signup with "Setup crew, Sat Nov 21" and "Cleanup crew, Sun Nov 22", moving Setup crew to Nov 28 leaves it first, so the public page and the builder both read Nov 28, then Nov 22. A participant scanning down the list by date meets the later day first, and nothing tells the organizer the list is now out of order.

Slots are shown by sortOrder first and their date second (SLOT_DISPLAY_ORDER in src/services/locks.ts). updateSlot in src/services/slots.ts sets the new slotAt but leaves sortOrder alone. Keeping the organizer's own order is deliberate, since they can drag rows; the gap is the case where the list was in date order and one edit broke it.

Fix, in outline

  • In updateSlot, when a slot's slotAt changes and the signup's other slots were already in date order (by slotAt, with the moved slot in its old place), give the moved slot the place that keeps date order, renumbering through writeSlotOrder as reorderSlots does.
  • When the list wasn't in date order before the edit, change nothing: the organizer arranged it by hand.
  • Slots with no date stay where they are.
  • The builder shows the row in its new place after the save, not only after a reload.

Choices this makes

  • Move it automatically, only when the list was already in date order. Default: yes. A list sorted by date is almost always meant to be, and a list arranged by hand is left alone. The alternative, a "Sort by date" button, adds a control and still leaves the list wrong until someone notices.
  • The same rule for the AI tools. Default: yes, since update_slot calls the same service.

Watch for

  • src/services/slots.db.test.ts and the capacity and reschedule tests: the moved slot's slot.rescheduled row and its commitments must not change.
  • Signups grouped by date: the moved slot must land in its new day's group, and the groups must stay in date order.
  • The row's position moving under the organizer's mouse right after Done. If that's jarring in the builder, keep the move but don't animate it.
  • CHANGELOG entry.

Done when

  • On a date-ordered signup, changing one slot's date moves it to its date's place, in the builder and on /s/[slug], with its sign-ups unchanged.
  • On a hand-ordered signup, changing a date moves nothing.
  • A DB test pins both cases.
  • pnpm lint && pnpm typecheck && pnpm knip && pnpm test && pnpm test:db pass.

Found by the UX walkthrough, scenario O4, on opensignup-prod main at 651da5b (this repo at 208a077). Checked against SLOT_DISPLAY_ORDER and updateSlot at 208a077.

Generated by Claude Code

Lingua principale
TypeScript
Stelle
19
Fork
4
Merge medio
19h 27m
PR unite (30g)
199

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di richshaw/OpenSignup

Tutte le issue di richshaw/OpenSignup

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.