Magic Compose calls fields "columns" on the draft banner, the drafting screen and its warnings

Chiusa Adatta ai principianti
  • Qualcosa non va?
#719 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
85/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
react, typescript
Ambito
frontend

Direzione di ricerca

Inizia in src/components/magic-compose/AiDraftBanner, Drafting.tsx, Steps.tsx e src/lib/magic-compose/to-template.ts; sostituisci le stringhe 'column' elencate con la dicitura esatta 'field'. Aggiorna to-template.test.ts per corrispondere alle nuove frasi di avviso. Fatto quando pnpm lint && pnpm typecheck && pnpm knip && pnpm test passano e nessun 'column' rivolto agli organizer rimane fuori da CSS.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug pipeline:ready pipeline:ux

What happens

After an AI draft, the Build tab's banner says "Here's your draft, 2 columns and 3 slots". The Build tab itself calls the same things Fields (its button reads "Fields (2)"), and docs/writing-help.md says to call them fields and never columns. Organizers see the word "column" in four places, all in Magic Compose:

  • The draft banner: AiDraftBanner builds its title as "Here's your draft, N column(s) and N slot(s)".
  • The drafting screen: Drafting labels the live preview's field chips "Columns".
  • The step list: DRAFT_STEPS in src/components/magic-compose/Steps.tsx has "Choosing columns for each slot", shown on the reading, questions and drafting screens.
  • The "A few things to double-check" warnings: buildWarnings in src/lib/magic-compose/to-template.ts says "cell(s) … didn't match the column's format", "Column(s) X arrived without a fixed list of options", "duplicate column(s)" and "didn't match any column".

Fix, in outline

Use these exact strings:

  • Banner: "Here's your draft, 2 fields and 3 slots", and "1 field" for one.
  • Drafting screen label: "Fields".
  • Step: "Choosing fields for each slot". Keep its id: 'fields'.
  • Warnings:
    • "1 value was left blank because it didn't fit its field. Fill it in below." / "3 values were left blank because they didn't fit their fields. Fill them in below."
    • "Field Shift arrived without a fixed list of options, so it was switched to free text." / "Fields Shift, Role arrived without …, so they were switched to free text."
    • "Removed 2 duplicate fields the AI tried to add twice." (singular "field")
    • "Ignored 2 stray values that didn't match any field."

Watch for

  • Leave the AI-facing text alone. "Fields are columns the organizer fills in" in src/lib/signup-rules.ts, src/lib/magic-compose/persist.ts and the MCP tool descriptions (src/mcp/tools/guides.ts, fields.ts, signups-read.ts) explains fields to a model, not to an organizer. signup-rules.ts is also pinned by magic-compose/__golden__/system-prompt.txt and RULES_IN_BOTH, so changing it would need an eval run. It's out of scope here.
  • CSS names stay. gridTemplateColumns and the like in Drafting.tsx are layout, not words people read.
  • Tests that pin the old wording: to-template.test.ts matches /cell was left blank/. Update it to the new sentence rather than loosening it.
  • #718 also edits Steps.tsx (the step label colours, a few lines below DRAFT_STEPS). Whichever lands second has a small merge to make.
  • CHANGELOG: add an entry under "Changed". No help page uses these strings (checked src/help).

Done when

  • None of the strings above say "column", and grepping src/components and src/lib/magic-compose/to-template.ts finds no organizer-facing "column" outside CSS names.
  • A test pins the banner title for one field and for several ("1 field", "2 fields and 3 slots").
  • to-template.test.ts checks the new warning sentences.
  • pnpm lint && pnpm typecheck && pnpm knip && pnpm test pass.

From the owner's notes (a screenshot of the draft banner, asking "They're fields not columns right?"), checked against 2d4fdfe on main. https://claude.ai/code/session_016YZ9SWYPU95kTg4qsmYbzE

Lingua principale
TypeScript
Stelle
19
Fork
4
Merge medio
19h 27m
PR unite (30g)
199

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di richshaw/OpenSignup

Tutte le issue di richshaw/OpenSignup

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.