Organizers have no saved language
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Idoneità per principianti
- 25/100
- Tipo di issue
- Funzionalità
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- next.js, typescript
- Ambito
- authentication, backend, internationalization
Direzione di ricerca
Start with #625 and the existing session flow in src/auth/organizer-session.ts, src/auth/bearer.ts, and src/mcp/context.ts; then read the locale helpers and Account Settings entry points named in the issue. Implement the stored locale, audience-filtered fallback order, and tests listed under “Done when,” including the database query check. Done means the listed lint, typecheck, knip, unit, and database commands pass.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Needs your OK: this adds a language to each organizer's account, used for their new signups now and for the app itself later. Nothing shows until Swedish ships; the privacy page says we store it. Swap pipeline:proposed for pipeline:ready to have it built.
What happens
New signups should start in their organizer's language (the next step in #619), and later the app should use it too. There's nowhere to keep it:
- The browser's
Accept-Languageis a weak guess. Many Swedes run their phones in English. - AI assistants have no browser at all. They create signups through MCP.
Fix, in outline
-
organizers.locale: a nullable text column, added with a Drizzle migration. It's lenient like the signup's (#625). -
getOrganizerLocale(session, acceptLanguage | null)insrc/i18n/organizer.tsworks out the effective language, in this order:- the saved value;
DEFAULT_LOCALE, when the operator set it (#625);- on a browser request, the browser's top-ranked
Accept-Languagelanguage, if it's shipped (only the top one: normal negotiation would matchsv,en;q=0.8to English); - English.
Each step is filtered by the audience's
SHIPPEDlist. -
No new query.
OrganizerSessiongainslocale, selected in the queryloadOrganizerSessionByIdalready runs (src/auth/organizer-session.ts). It travels throughgetOrganizerSession()to routes, and throughBearerResolution(src/auth/bearer.ts) into the MCPToolContext(src/mcp/context.ts), because tool handlers may not query the database themselves. -
MCP passes
nullfor the browser. An assistant'sAccept-Languageis the vendor's, not the organizer's. -
updateOrganizerLocale(db, actor, locale)lets an organizer change only their own. The value must be inSHIPPED.participant. -
Account Settings gets "Language for new signups", rendered only when
SHIPPED.participanthas more than one entry. -
The privacy page says we store the organizer's language setting, and its "Last updated" date moves.
Watch for
- Keep it out of
src/i18n/server.ts. The worker imports that file undertsx, andgetOrganizerLocalemay neednext/headers. - Sign-in and bearer code go to the owner as high risk.
- Tests that build
OrganizerSessionby hand gain the field:src/auth/bearer.test.ts,src/oauth/flow.db.test.tsandsrc/app/app/signups/[id]/preview/page.test.tsx. - The Auth.js adapter and the e2e seed's organizer insert are unaffected by a nullable column.
Choices this makes
- Store it on the organizer, not in a cookie. Default: a column. It works without a browser, follows them across devices, and needs no cookies-page change.
- One setting for new signups now and the app later. Default: one. Someone who wants the app in English but signups in Swedish changes each signup's language in its Settings tab; a second setting can come if people ask for it.
- The order: saved →
DEFAULT_LOCALE→ the browser's first language → English.
Order
After #625, because defaultFor, DEFAULT_LOCALE and the lenient-language rule come from it.
Done when
- Unit tests cover every step of the order, including MCP's
nulland asv,en;q=0.8browser before Swedish ships. - A db test shows
loadOrganizerSessionByIdreturnslocalewith no extra statement. pnpm lint && pnpm typecheck && pnpm knip && pnpm testandpnpm test:dbpass.
Planned with the owner in https://claude.ai/code/session_01EFKmj716ZY3b3SwR8TV8Y2 and checked against the code on main at 35288fa. The full plan is private to the owner's account: https://claude.ai/artifact/VgQH6U2s2EVx3LX991fJi8 (a Claude session on that account can open it with the Artifact tool's read action). This is part of step 1.1 there.
- Lingua principale
- TypeScript
- Stelle
- 19
- Fork
- 4
- Merge medio
- 21h 3m
- PR unite (30g)
- 176
Preparare l'ambiente
- Include un Dockerfile o un file Docker Compose
- Nessun modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di richshaw/OpenSignup
-
enhancement pipeline:proposed pipeline:ux
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
richshaw/OpenSignup#654 ·
I maintainer di solito rispondono entro 1 giorno
-
The help pages never say "pause", so organizers looking for it miss Close or reopen a signupForse già presa @richshaw l’ha presa 1 giorno fa. Apertaenhancement pipeline:building pipeline:ux
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
richshaw/OpenSignup#653 · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement pipeline:proposed pipeline:ux
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
richshaw/OpenSignup#652 ·
I maintainer di solito rispondono entro 1 giorno
-
SMTP timeout notes in smtp.ts and the changelog describe nodemailer 10.0, not 10.1Forse già presa @agammann l’ha presa 2 giorni fa. Apertaenhancement good first issue pipeline:ready
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
richshaw/OpenSignup#645 ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement pipeline:proposed pipeline:ux
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
richshaw/OpenSignup#589 ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di richshaw/OpenSignup
Issue simili
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
scaleway/ultraviolet#7089 ·
I maintainer di solito rispondono entro 2 giorni
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 67/100
tencent-connect/dsh-qqbot#81 ·
I maintainer di solito rispondono entro 1 giorno
-
[Bug]: Pen taps on sidebar rows start a drag and lose their clickForse già presa @makhnatkin l’ha presa oggi. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
I maintainer di solito rispondono entro 1 giorno
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 66/100
clangd/vscode-clangd#1009 ·