Under RN_STRICT_API no feature-flag header is public, so a library cannot read a flag and an app cannot override one
I maintainer di solito rispondono entro 2 giorni
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 45/100
Direzione di ricerca
Start by reading ReactNativePublicFeatureFlags.h, the feature flag headers under react/featureflags/, and PrivateGuard.h; the reproducer names the affected flags and the strict API compile that fails. Run the reproducer’s repro.sh to confirm the failure, then inspect the public header and override declarations. Done means strict API consumers can read the named flags and override one, while builds without RN_STRICT_API still compile.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Description
Every header in react/featureflags/ but ReactNativePublicFeatureFlags.h includes react/cxxstableapi/PrivateGuard.h, which is an #error once a build defines RN_STRICT_API. ReactNativePublicFeatureFlags.h declares ReactNativeFeatureFlags_DO_NOT_USE with seven flags and no way to override one. So with the strict C++ API on:
- a library whose Fabric code must agree with a flag (
preventShadowTreeCommitExhaustion,enableFabricCommitBranching,updateRuntimeShadowNodeReferencesOnCommit,cxxNativeAnimatedEnabled,enableFlexboxAutoMinSizeInStrictMode) has no header it may include to read it; - an app has no header it may include to override a flag through
ReactNativeFeatureFlagsOverridesOSSExperimentalorReactNativeFeatureFlags::override.
0.88.1 has the <React/FeatureFlags.h> umbrella for both; #58744 removed it and made the module private, from 0.89.0-rc.0.
Expected: a consumer that defines RN_STRICT_API can read every flag and override flags through a header the guards accept. Builds without RN_STRICT_API stay as they are.
Steps to reproduce
- Clone the reproducer below.
ReproducerApp/cpp/FlagReader.cppreads the five flags above through<react/featureflags/ReactNativeFeatureFlags.h>;ReproducerApp/cpp/FlagOverrides.cppoverrides one with aReactNativeFeatureFlagsOverridesOSSExperimentalsubclass andReactNativeFeatureFlags::override. - Run its
repro.sh:
It sparse-clones react/react-native atdocker run --rm -v "$PWD:/repro:ro" gcc:15 bash /repro/repro.shmainand compiles both files against itsReactCommonwith-fsyntax-only, once plain and once with-DRN_STRICT_API.bash repro.sh v0.89.0-rc.1does the same on the release candidate. - Expected: both files compile with
-DRN_STRICT_API, or a public header offers the same reads and the override. Actual: both compile without it and stop on the private-header#errorwith it, and the public header declares none of the five flags:
The script exits 1 while a strict compile stops on thatreact/react-native de7e643aa30b4e87376898b74037bd9712e9d4d6 == which flags ReactNativePublicFeatureFlags.h declares class ReactNativeFeatureFlags_DO_NOT_USE { preventShadowTreeCommitExhaustion: not declared enableFabricCommitBranching: not declared updateRuntimeShadowNodeReferencesOnCommit: not declared cxxNativeAnimatedEnabled: not declared enableFlexboxAutoMinSizeInStrictMode: not declared == FlagReader.cpp without RN_STRICT_API compiles == FlagReader.cpp with -DRN_STRICT_API react/cxxstableapi/PrivateGuard.h:32:2: error: #error "This is a private React Native header and is not part of the public API. Do not include it directly; it has no stability guarantee." == FlagOverrides.cpp without RN_STRICT_API compiles == FlagOverrides.cpp with -DRN_STRICT_API react/cxxstableapi/PrivateGuard.h:32:2: error: #error "This is a private React Native header and is not part of the public API. Do not include it directly; it has no stability guarantee." SUMMARY: under RN_STRICT_API 2 of 2 files stop on the private-header #error: no feature-flag header is public (react/react-native de7e643aa3)#errorand 0 once both compile.
React Native Version
0.89.0-rc.1
Affected Platforms
Build - Linux, Build - Windows
Areas
Fabric - The New Renderer
Output of npx @react-native-community/cli info
System:
OS: Linux 6.18 Debian GNU/Linux 13 (trixie) 13 (trixie)
CPU: (24) x64 AMD Ryzen 9 9950X3D 16-Core Processor
Memory: 120.35 GB / 125.63 GB
Shell:
version: 5.2.37
path: /bin/bash
Binaries:
Node:
version: 24.22.3
path: /usr/bin/node
Yarn: Not Found
npm:
version: 11.19.1
path: /usr/bin/npm
Watchman: Not Found
SDKs:
Android SDK: Not Found
IDEs:
Android Studio: Not Found
Languages:
Java: Not Found
Ruby: Not Found
npmPackages:
"@react-native-community/cli":
installed: 21.0.0
wanted: ^21.0.0
react: Not Found
react-native:
installed: 0.89.0-rc.1
wanted: ^0.89.0-rc.1
npmGlobalPackages:
"*react-native*": Not Found
Android:
hermesEnabled: Not found
newArchEnabled: Not found
iOS:
hermesEnabled: Not found
newArchEnabled: Not found
Stacktrace or Logs
react/cxxstableapi/PrivateGuard.h:32:2: error: #error "This is a private React Native header and is not part of the public API. Do not include it directly; it has no stability guarantee."
MANDATORY Reproducer
https://github.com/YevheniiKotyrlo/react-native-feature-flags-under-strict-cxx-api
Screenshots and Videos
No response
- Lingua principale
- C++
- Stelle
- 127k
- Fork
- 25.5k
- Merge medio
- 3g 22h
- PR unite (30g)
- 235
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di react/react-native
-
Needs: Author Feedback Needs: Repro
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
react/react-native#60059 · 1 commento ·
I maintainer di solito rispondono entro 2 giorni
-
Needs: Triage :mag:
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
react/react-native#60000 ·
I maintainer di solito rispondono entro 2 giorni
-
`yarn test-ios` exits before building RNTester: `objc-test.sh` launches the WebSocket server script #59433 deletedForse già presa @lazerg l’ha presa 4 giorni fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
react/react-native#59939 ·
I maintainer di solito rispondono entro 2 giorni
-
iOS Fabric pointer-handler reset leaves the next lone touch non-primaryForse già presa @alleneubank l’ha presa 6 giorni fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
react/react-native#59919 ·
I maintainer di solito rispondono entro 2 giorni
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
react/react-native#59722 ·
I maintainer di solito rispondono entro 2 giorni
Tutte le issue di react/react-native
Issue simili
-
crash generated by fuzzer mlir
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
llvm/llvm-project#243218 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
petercorke/robotics-toolbox-python#943 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
realtime
Difficoltà 2/5 1-3 ore Idoneità per principianti 69/100
NVIDIA/cuda-quantum#5913 ·
I maintainer di solito rispondono entro 1 giorno
-
[hidapi] update to 0.16.0Apertacategory:port-update
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
I maintainer di solito rispondono entro 2 giorni
-
area:build bug
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 90/100
NatronGitHub/openfx-arena#71 ·
I maintainer di solito rispondono entro 1 giorno