IOS and ANDROID onChange Event do not share the same value but have the same type

Aperta
  • Qualcosa non va?
#927 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

  • #1064 di @cpruijsen — chiusa senza merge

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
38/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Ferma
Stack tecnologico
react-native, typescript
Ambito
frontend, mobile

Direzione di ricerca

The report identifies the DateTimePicker onChange callback type and a mismatch between iOS and Android values, but names no source files or tests. Start by tracing the callback type definitions and platform implementations, then look for existing callback tests. Done when the type reflects the value returned on iOS and the mismatch is covered by a test.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Bug report

Summary

DatePicker onChange value is not the same between IOS and ANDROID but both actually share the same type, leading to TS invalid type when trying to accessing "unexisting" property

Reproducible sample code

		<DateTimePicker
			value={birthdate}
			is24Hour={true}
			onChange={(
			        value: DateTimePickerEvent & {
				nativeEvent: { target?: number };
			}) => {
				if (value.nativeEvent.target) {
					// operation on date change
			}}
		/>

Steps to reproduce

Set a DatePicker component anywhere with anydata and run it on IOS, this was tested with mode "compact"

Describe what you expected to happen:

IOS onChange type should be following the actual data returned

Environment info

EXPO SDK 51.0

System:
  OS: Linux 5.15 Ubuntu 22.04.4 LTS 22.04.4 LTS (Jammy Jellyfish)
  CPU: (16) x64 12th Gen Intel(R) Core(TM) i7-1260P
  Memory: 1.64 GB / 4.81 GB
  Shell:
    version: 5.8.1
    path: /bin/zsh
Binaries:
  Node:
    version: 20.5.1
    path: /usr/bin/node
  Yarn:
    version: 1.22.22
    path: /usr/bin/yarn
  npm:
    version: 10.8.2
    path: /usr/bin/npm
  Watchman: Not Found
SDKs:
  Android SDK: Not Found
IDEs:
  Android Studio: Not Found
Languages:
  Java:
    version: 17.0.12
    path: /usr/bin/javac
  Ruby: Not Found
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.74.5
    wanted: 0.74.5
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: Not found
  newArchEnabled: Not found
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found

datetimepicker version: 2.7.5

Lingua principale
JavaScript
Stelle
2.9k
Fork
459
Merge medio
4g 16h
PR unite (30g)
5

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di react-native-datetimepicker/datetimepicker

Tutte le issue di react-native-datetimepicker/datetimepicker

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.