Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Handle restored date filters when DataTable and DataView metadata changes after mount

Aperta
  • Qualcosa non va?
#944 0 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 5 giorni

@Shreyag02 ci sta già lavorando.

Dal 6/10/2026.

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

Summary

Handle restored date filters when field metadata gains filterType: 'date' after mount in both DataTable and DataView.

  • DataTable: columns can gain date-filter metadata after DataTableRoot initializes tableQuery.
  • DataView: root fields can change after mount, and a view's fields override can register after the initial query loads. These changes affect effectiveFields.

In both cases, an untyped restored date filter can remain untyped. Client filtering can then match no rows, and server query emission can use string-filter behavior instead of date-filter behavior.

This limitation predates PR #919. The follow-up is separate from that PR.

Required changes

  • Derive missing filter types from the current DataTable columns and DataView effectiveFields when computing row-filter state and emitted queries.
  • Use the shared date-filter metadata helper where appropriate.
  • Preserve existing filter values, operators, explicit types, and user edits.
  • Do not reinitialize tableQuery from the original query or add an effect that replaces user edits.
  • Ensure DataView uses the active view's effective metadata, including its fields override.

Affected areas

  • DataTable: DataTableRoot, row-filter state derivation, and server query emission. The reviewed root file is packages/react/components/data-table/data-table.tsx.
  • DataView: DataViewRoot, effectiveFields, row-filter state derivation, and server query emission.
  • Shared date-filter metadata helpers and DataTable/DataView regression tests.

Acceptance criteria

  • Mount DataTable with an untyped restored date filter, then give its column filterType: 'date'. Client filtering compares whole days and selects the expected rows.
  • Repeat this scenario in DataView for both updated root fields and a view's late-registering fields override.
  • In server mode, both components emit the restored filter with date semantics and a viewer-local YYYY-MM-DD stringValue after date metadata becomes available.
  • Preserve the original filter value and any user edits made before metadata arrives.
  • Leave explicitly typed filters and unrelated filters unchanged.
  • Add regression tests for both components, including client filtering and server query emission.

References

Requested by @Shreyag02.

Lingua principale
TypeScript
Stelle
69
Fork
13
Merge medio
4g 4h
PR unite (30g)
27

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di raystack/apsara

Tutte le issue di raystack/apsara

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.