Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Handle restored date filters when DataTable and DataView metadata changes after mount

Abierto
  • ¿Algo no está bien?
#944 0 comentarios 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 5 días

@Shreyag02 ya está trabajando en esto.

Desde el 6/10/2026.

Evaluación

Este issue todavía no se ha evaluado.

Descripción

Summary

Handle restored date filters when field metadata gains filterType: 'date' after mount in both DataTable and DataView.

  • DataTable: columns can gain date-filter metadata after DataTableRoot initializes tableQuery.
  • DataView: root fields can change after mount, and a view's fields override can register after the initial query loads. These changes affect effectiveFields.

In both cases, an untyped restored date filter can remain untyped. Client filtering can then match no rows, and server query emission can use string-filter behavior instead of date-filter behavior.

This limitation predates PR #919. The follow-up is separate from that PR.

Required changes

  • Derive missing filter types from the current DataTable columns and DataView effectiveFields when computing row-filter state and emitted queries.
  • Use the shared date-filter metadata helper where appropriate.
  • Preserve existing filter values, operators, explicit types, and user edits.
  • Do not reinitialize tableQuery from the original query or add an effect that replaces user edits.
  • Ensure DataView uses the active view's effective metadata, including its fields override.

Affected areas

  • DataTable: DataTableRoot, row-filter state derivation, and server query emission. The reviewed root file is packages/react/components/data-table/data-table.tsx.
  • DataView: DataViewRoot, effectiveFields, row-filter state derivation, and server query emission.
  • Shared date-filter metadata helpers and DataTable/DataView regression tests.

Acceptance criteria

  • Mount DataTable with an untyped restored date filter, then give its column filterType: 'date'. Client filtering compares whole days and selects the expected rows.
  • Repeat this scenario in DataView for both updated root fields and a view's late-registering fields override.
  • In server mode, both components emit the restored filter with date semantics and a viewer-local YYYY-MM-DD stringValue after date metadata becomes available.
  • Preserve the original filter value and any user edits made before metadata arrives.
  • Leave explicitly typed filters and unrelated filters unchanged.
  • Add regression tests for both components, including client filtering and server query emission.

References

Requested by @Shreyag02.

Lenguaje dominante
TypeScript
Estrellas
69
Forks
13
Merge medio
4 d 4 h
PR fusionados (30 d)
27

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de raystack/apsara

Todos los issues de raystack/apsara

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.