Convert the adapter types and the remaining Enums classes to PHP enums (PHP 8.2)
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Idoneità per principianti
- 35/100
Direzione di ricerca
Start by reading the listed adapter type classes and the factories, Database, PaginatorFactory, and Status trait named in the issue. Then trace the listed property and parameter defaults, config and .env inputs, starter project, module templates, and documentation examples that use these classes. Check every conversion against the PHP 8.2 enum value behavior described in the issue; done means all listed classes are converted or have a recorded reason to remain constants, the examples and templates work, the changelog and upgrade guide are updated, and the stated CI checks pass.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Summary
Convert the remaining classes in the Enums folders to PHP enums in 3.2.0, once PHP 8.2 is the minimum: the adapter types, StatusCode, ContentType, Env and ExitCode. The first batch, the classes that can convert on PHP 8.1, is #612.
Why 3.2.0
These classes appear in class constants, property defaults or parameter defaults, mostly as the keys of maps, and PHP 8.1 does not allow Case->value in a constant expression. PHP 8.2 does (the RFC "Fetch properties of enums in const expressions"). I checked it on PHP 8.2.35 and 8.1.34:
public const ADAPTERS = [LoggerType::SINGLE->value => SingleAdapter::class, ...]loads and works on 8.2.- The same code fails on 8.1 with
Fatal error: Constant expression contains invalid operations, and so does the realLoggerFactory.phpwith its keys written that way.
With 8.2 the maps keep their shape. In each place only ->value is added to the keys.
Classes in this ticket
- Adapter types (15):
AppType,ArchiveType,AuthType,CacheType,CaptchaType,CryptorType,DatabaseType,FileSystemType,LangType,LoggerType,MailerType,PaginatorType,RateLimitType,RendererType,SessionType. - Others:
ContentType,Env,ExitCode,StatusCode(62 integer cases).
Places that need ->value
- the 15
ADAPTERSconstants in the factories andDatabase PaginatorFactory::REQUIRED_PARAMS- the
Statustrait's$textsmap, with the status codes as keys - the property and parameter defaults that hold these classes
What to watch
- An enum case is not its value:
StatusCode::OK === 200is false, and anintparameter rejects a case. Comparisons, array keys and parameters that use the value need->value, and text from config or.envneeds::from()or::tryFrom(). - Apps and templates use these constants, for example
AppFactory::create(AppType::WEB, ...)in the starter project andPaginatorTypein the Toolkit templates. Signatures typedstring $typechange.
Out of scope
ExceptionMessages, whose classes extend a shared base class.- The classes in #612.
Breaking changes
- Public constants become enum cases, and the type of some public parameters and return values changes. To be listed in the changelog and in the upgrade guide.
Acceptance criteria
- every class above is converted or has a recorded reason to stay a constants class
- the starter project and the module templates still work, and the docs examples use the new form
composer test,composer cs:check,composer phpstanandcomposer rector:checkpass on every PHP version in the CI matrix- the changelog lists every converted class
- Lingua principale
- PHP
- Stelle
- 43
- Fork
- 22
- Merge medio
- 54m
- PR unite (30g)
- 57
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Nessun modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di quantum-php/framework
-
bug good first issue
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
quantum-php/framework#692 ·
I maintainer di solito rispondono entro 1 giorno
-
routing testing
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
quantum-php/framework#547 ·
I maintainer di solito rispondono entro 1 giorno
-
bug
Difficoltà 3/5 1-2 giorni Idoneità per principianti 72/100
quantum-php/framework#694 ·
I maintainer di solito rispondono entro 1 giorno
-
Raise PHPStan to level 9Apertarefactoring tech debt
Difficoltà 5/5 Più di una settimana Idoneità per principianti 20/100
quantum-php/framework#693 ·
I maintainer di solito rispondono entro 1 giorno
-
install:debugbar reads the package folder from the working directory and uses the default storage adapterForse già presa @armanist l’ha presa oggi. Apertabug console debugbar good first issue
quantum-php/framework#691 · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di quantum-php/framework
Issue simili
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 70/100
ajeetraina/awesome-docker-sbx#559 ·
-
dependencies enhancement
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
novalo-dev/Prestashop-MCP-Server#329 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 80/100
I maintainer di solito rispondono entro 1 giorno
-
bug origin:interactive status:available
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
Ultimate-Multisite/ultimate-multisite#2131 ·
I maintainer di solito rispondono entro 1 giorno
-
sync-en
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
I maintainer di solito rispondono entro 1 giorno