`x *= seq` raises TypeError for int subclasses and IntEnum where `x * seq` works

Aperta
#161,968 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
1-2 giorni
Idoneità per principianti
25/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Ferma
Stack tecnologico
c, python
Ambito
compilers

Direzione di ricerca

Start with PyNumber_InPlaceMultiply in Objects/abstract.c and compare its handling of the right operand's sq_repeat with PyNumber_Multiply. Find the relevant existing numeric or sequence-operation tests; the issue does not name a test file. Done means in-place multiplication matches ordinary multiplication for the reported int subclass and IntEnum cases, with tests passing.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Bug report

When the left operand is an instance of a Python class that supports __index__ but has no __mul__/__imul__ that handles sequences (an int subclass, an IntEnum member, or any class with __index__), x *= [1] raises TypeError, while x * [1] and x = x * [1] work. With a plain int on the left it works.

import enum, operator

class MyInt(int):
    pass

class Number(enum.IntEnum):
    TWO = 2

x = MyInt(2)
print(x * [1])              # [1, 1]
x *= [1]                    # TypeError: unsupported operand type(s) for *=: 'MyInt' and 'list'

y = Number.TWO
y *= [1]                    # TypeError: unsupported operand type(s) for *=: 'Number' and 'list'

operator.imul(MyInt(2), [1])  # same TypeError

Expected: [1, 1] in each case, the same as x * [1].

The cause is in PyNumber_InPlaceMultiply (Objects/abstract.c): the right operand's sq_repeat is only tried in an else if (mw != NULL) branch, which is skipped whenever the left operand's type has a tp_as_sequence at all, even if that has no repeat slot. Every heap type has tp_as_sequence, so for these classes the list's repeat is never reached. PyNumber_Multiply does not have this problem because it checks the right operand independently.

CPython versions tested on:

3.15, CPython main branch

Operating systems tested on:

Linux


Found while building a Lean 4 model of CPython (https://broyojo.com/python-formalization/). AI tools (Claude) helped investigate the findings and prepare this report. The examples were rerun on CPython 3.15.2 and main, and the report received technical review. Record: corelibs-inplace-mul-heap-left

Linked PRs
  • gh-161969
Lingua principale
Python
Stelle
78.2k
Fork
36.6k
Merge medio
19h 57m
PR unite (30g)
630

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di python/cpython

Tutte le issue di python/cpython

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.