Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Wrong presence channel behavior (Android/IOS)

Aperta
  • Qualcosa non va?
#299 2 commenti 2 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Ferma
Stack tecnologico
android, ios, java
Ambito
mobile-dev

Direzione di ricerca

The problem is in PresenceChannelImpl, in handleSubscriptionSuccessfulMessage, where idToUserMap is filled with put() calls but never cleared before the new user list is applied. Start by reading how idToUserMap is maintained across unsubscribe and resubscribe in PresenceChannelImpl. Done means that after a reconnect, getUsers() reflects only the users in the subscription_succeeded payload, and that a test covers a member leaving while the client was disconnected.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug
What is the issue?

Hello there! I found some incorrect behavior of presence channels after restore connection to channel.

Problem step-by-step:

  1. Connect to presence channel two or more users
  2. Go to in background - pusher disconnected
  3. Other users quit from channel
  4. Go to in foreground - pusher connected - we resubscribe to channel
  5. On onUsersInformationReceived we got old data of users in channel

Notate: Swift SDK has workaround with subscribing on "pusher:subscription_succeeded" and process this event separate from flow logic. In Java SDK we don't have such trick...

In PresenceChannelImpl when channel successfully subscribed we got event SUBSCRIPTION_SUCCESS_EVENT = "pusher_internal:subscription_succeeded" with processing in internal channel body and after that call onUsersInformationReceived for self interface.

Problem in idToUserMap map witch need to clear in this case, because if i'm not wrong with SUBSCRIPTION_SUCCESS_EVENT we getting actual data about users in presence channel but in current realisation we lost users who quit from channel while i was unsubscibed.

Debug of this point shown that problem exist - channel got json with 1 user but idToUserMap not cleared and return wrong users data

...

Is it a crash report? Submit stack traces or anything that you think would help
#class PresenceChannelImpl

@SuppressWarnings({ "rawtypes", "unchecked" })
    private void handleSubscriptionSuccessfulMessage(final String message) {
        final ChannelEventListener listener = getEventListener();

        // extract data from the JSON message
        final PresenceData presenceData = extractPresenceDataFrom(message);
        if (presenceData == null) {
            if (listener != null) {
                listener.onError(
                    "Subscription failed: Presence data not found",
                    null
                );
            }
            return;
        }

        final List<String> ids = presenceData.ids;
        final Map<String, Object> hash = presenceData.hash;

        if (ids != null && !ids.isEmpty()) {
            // build the collection of Users
            for (final String id : ids) {
                final String userData = hash.get(id) != null ? GSON.toJson(hash.get(id)) : null;
                final User user = new User(id, userData);
                idToUserMap.put(id, user);  <--- Problem - is not empty. Suggestion: need clear before process users data
            }
        }

        if (listener != null) {
            final PresenceChannelEventListener presenceListener = (PresenceChannelEventListener)listener;
            presenceListener.onUsersInformationReceived(getName(), getUsers());
        }
    }

...

Any improvements you suggest

In this case clear idToUserMap before process users data. I may be wrong, then tell me the correct scenario for working with this type of channels
...

CC @pusher/mobile

Lingua principale
Java
Stelle
315
Fork
140
Merge medio
11g 5h
PR unite (30g)
4

Preparare l'ambiente

  • Nessun Dockerfile né file Docker Compose
  • Ha un modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di pusher/pusher-websocket-java

Tutte le issue di pusher/pusher-websocket-java

Issue simili

Altre issue su Java

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.