Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Wrong presence channel behavior (Android/IOS)

Abierto
  • ¿Algo no está bien?
#299 2 comentarios 2 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Estancado
Stack tecnológico
android, ios, java
Área
mobile-dev

Línea de trabajo

The problem is in PresenceChannelImpl, in handleSubscriptionSuccessfulMessage, where idToUserMap is filled with put() calls but never cleared before the new user list is applied. Start by reading how idToUserMap is maintained across unsubscribe and resubscribe in PresenceChannelImpl. Done means that after a reconnect, getUsers() reflects only the users in the subscription_succeeded payload, and that a test covers a member leaving while the client was disconnected.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug
What is the issue?

Hello there! I found some incorrect behavior of presence channels after restore connection to channel.

Problem step-by-step:

  1. Connect to presence channel two or more users
  2. Go to in background - pusher disconnected
  3. Other users quit from channel
  4. Go to in foreground - pusher connected - we resubscribe to channel
  5. On onUsersInformationReceived we got old data of users in channel

Notate: Swift SDK has workaround with subscribing on "pusher:subscription_succeeded" and process this event separate from flow logic. In Java SDK we don't have such trick...

In PresenceChannelImpl when channel successfully subscribed we got event SUBSCRIPTION_SUCCESS_EVENT = "pusher_internal:subscription_succeeded" with processing in internal channel body and after that call onUsersInformationReceived for self interface.

Problem in idToUserMap map witch need to clear in this case, because if i'm not wrong with SUBSCRIPTION_SUCCESS_EVENT we getting actual data about users in presence channel but in current realisation we lost users who quit from channel while i was unsubscibed.

Debug of this point shown that problem exist - channel got json with 1 user but idToUserMap not cleared and return wrong users data

...

Is it a crash report? Submit stack traces or anything that you think would help
#class PresenceChannelImpl

@SuppressWarnings({ "rawtypes", "unchecked" })
    private void handleSubscriptionSuccessfulMessage(final String message) {
        final ChannelEventListener listener = getEventListener();

        // extract data from the JSON message
        final PresenceData presenceData = extractPresenceDataFrom(message);
        if (presenceData == null) {
            if (listener != null) {
                listener.onError(
                    "Subscription failed: Presence data not found",
                    null
                );
            }
            return;
        }

        final List<String> ids = presenceData.ids;
        final Map<String, Object> hash = presenceData.hash;

        if (ids != null && !ids.isEmpty()) {
            // build the collection of Users
            for (final String id : ids) {
                final String userData = hash.get(id) != null ? GSON.toJson(hash.get(id)) : null;
                final User user = new User(id, userData);
                idToUserMap.put(id, user);  <--- Problem - is not empty. Suggestion: need clear before process users data
            }
        }

        if (listener != null) {
            final PresenceChannelEventListener presenceListener = (PresenceChannelEventListener)listener;
            presenceListener.onUsersInformationReceived(getName(), getUsers());
        }
    }

...

Any improvements you suggest

In this case clear idToUserMap before process users data. I may be wrong, then tell me the correct scenario for working with this type of channels
...

CC @pusher/mobile

Lenguaje dominante
Java
Estrellas
315
Forks
140
Merge medio
11 d 5 h
PR fusionados (30 d)
4

Preparar el entorno

  • Sin Dockerfile ni archivo de Docker Compose
  • Tiene una plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de pusher/pusher-websocket-java

Todos los issues de pusher/pusher-websocket-java

Issues similares

Más issues de Java

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.