[Bug]: Timeline jumps far up right after sending in a long thread
I maintainer di solito rispondono entro 1 giorno
Valutazione
- Difficoltà
- 2/5
- Tempo stimato
- 1-3 ore
- Idoneità per principianti
- 82/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- typescript
- Ambito
- frontend, performance, web-dev
Direzione di ricerca
Inizia con patches/@[email protected] e segui il controllo delle dimensioni di prepareMVCP attraverso getItemSize, setSize e addTotalSize. Usa la riproduzione standalone di LegendList descritta nell’issue per verificare il salto, quindi conferma che la rimozione dell’ultima riga durante uno scorrimento animato non fa più collassare la lista né la sposta vicino all’inizio.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Before submitting
- I searched existing issues and did not find a duplicate.
- I included enough detail to reproduce or investigate the problem.
Area
apps/web
Steps to reproduce
In the app it is timing dependent. It shows up most in long threads with long replies, especially on desktop with a busy main thread:
- Open a thread with a lot of history and long assistant replies, scrolled to the bottom.
- Send a message.
- About half a second later the timeline jumps far up, often near the top of the loaded history, and stays there.
A small page that renders only a LegendList (no T3 Code components or data), served by the apps/web dev server, reproduces it every time:
- Render a
LegendListwith 150 rows of about 900px each,estimatedItemSize={90},initialScrollAtEnd, andmaintainVisibleContentPosition={{ data: true, size: true }}(the timeline's options). - Scroll up a few screens.
- Call
listRef.current.scrollToEnd({ animated: true }). - While that scroll is running, remove the last row from
data.
Expected behavior
The list ends at the end, with 149 rows.
Actual behavior
The list lands on rows 0 and 1, about 25,000px from the end. The same steps without step 4 end at the end. Removing the last row without a scroll in flight keeps the position.
The same page reproduces in a separate plain app with pristine npm @legendapp/list 3.3.5, when built with Rolldown-based Vite (apps/web builds with Rolldown through vite-plus). With esbuild-based Vite it does not jump. Under the same Rolldown setup, 3.4.0 does not jump either.
Impact
Major degradation or frequent failure
Version or commit
main @ ed809f7ad2 (@legendapp/list 3.3.5 with T3 Code's patch). @legendapp/list 3.4.0 does not reproduce. Its changelog lists "End-following and animated programmatic scrolling now stay aligned through footer, viewport, and native layout changes."
Environment
Windows 11, desktop nightly and web client from vp run dev. Provider independent. The same code is in the React Native build that mobile uses.
Logs or stack traces
No errors. Reading listRef.current.getState() every frame during a jump in a long thread:
| Time after send | scroll |
contentLength |
Rows in data |
Rendered rows |
|---|---|---|---|---|
| before | 12,414 | 13,162 | 144 | 131 to 143 |
| 631 ms | 0 | 334 | 143 | 131 to 142 |
| 1,047 ms | 12,158 | 49,291 | 143 | 36 to 39 |
The element's scrollTop stayed about where it was the whole time; only LegendList's state reset. The row data never went empty. A totalSize listener caught the collapse. Its stack runs through checkResetContainers, calculateItemsInView, the MVCP check, getItemSize, setSize, and addTotalSize.
Screenshots, recordings, or supporting files
The standalone repro, unpatched:
https://github.com/user-attachments/assets/22c266c7-1763-42e4-ae23-851b2de6cc01
Workaround
Press End or use "Scroll to end".
Cause
scrollToEnd records the last index as state.scrollingTo. When data shrinks before that scroll completes, the MVCP check in prepareMVCP resolves the target with getId(state, scrollTarget). That index is now past the end of data, so it returns null. The check still sizes it:
if (scrollingToViewPosition && scrollingToViewPosition > 0) {
const newSize = getItemSize(ctx, targetId, scrollTarget, state.props.data[scrollTarget]);
getItemSize passes the null key to setSize, and addTotalSize treats a null key as "set the total to this value". The total height collapses to one estimated row. That sends the list to scroll = 0 and it re-lays out unmeasured rows at the average measured row height. In a thread of long replies that average is several times the 90px estimate, so the old offset now lands near the top.
In T3 Code the shrink comes from the timeline's trailing rows. When a turn starts, the live activity row at the end is replaced, which briefly removes one row while the send's scrollToEnd is still in flight. A busy main thread widens that window. The desktop running-thread keep-alive and very large environments made it frequent here, but neither is required.
Skipping that size check when targetId is null fixes the repro. I'll open a PR that adds the guard to patches/@[email protected].
- Lingua principale
- TypeScript
- Stelle
- 24.8k
- Fork
- 6.4k
- Merge medio
- 11h 33m
- PR unite (30g)
- 312
Preparare l'ambiente
Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di pingdotgg/t3code
-
accepted bug via-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
pingdotgg/t3code#18690 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
I maintainer di solito rispondono entro 1 giorno
-
[Bug] Windows repository cloning fails while creating an existing drive rootForse già presa @pujitha24 l’ha presa 1 giorno fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 73/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
I maintainer di solito rispondono entro 1 giorno
-
[Bug]: iOS still shows "Failed to connect. Retrying" on every resume (follow-up to #5695)Forse già presa @otavio l’ha presa oggi. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di pingdotgg/t3code
Issue simili
-
cleanName keeps a state code that's joined to the word before it (SavannahGa → "Savannah Ga")Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
openwatersio/slackwater-database#281 ·
I maintainer di solito rispondono entro 1 giorno
-
Bayern feature:Application ready web
Difficoltà 2/5 1-3 ore Idoneità per principianti 67/100
digitalfabrik/entitlementcard#3176 ·
I maintainer di solito rispondono entro 7 giorni
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
NanmiCoder/cc-haha#1533 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
I maintainer di solito rispondono entro 1 giorno
-
🐛 Bug: Calendar work items cannot be opened on mobileForse già presa Una pull request collegata a questa issue è aperta o già unita. Aperta
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 75/100
I maintainer di solito rispondono entro 1 giorno