Front end hardening: bound the descriptor-chain walk, thin query and configure log lines

Aperta
#61 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
64/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
cpp

Direzione di ricerca

Start in clean/fsr/src/frontend.cpp: the pNext walk in CreateContext (~line 460) and CreateUpscale (~533), and the logging in Query (~1445) and Configure (~1195), which should use ShouldLogDispatch (~446). Read config.h:113 and log_win.h:137 for the log_dispatches and size rules. Done when a self-referencing chain returns FFX_API_RETURN_ERROR_PARAMETER in a CPU test, and 1200 jitter queries with log_dispatches=1 leave about 2 query lines.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area: front-end enhancement

Two small, independent changes in clean/fsr/src/frontend.cpp. Found by reading the code; neither has been reproduced.

1. The descriptor-chain walk is not bounded

What happens

The walk over the pNext chain in CreateContext (:460) has no bound, and neither has the walk in CreateUpscale (:533). A chain that points back to itself would hang the calling thread. DescribeChain (clean/fsr/src/ffx_describe.cpp:337) stops at 16 nodes and CreateAmdWithoutPrivateVersion (frontend.cpp:192) stops at 64.

When it can happen

Only for a caller that breaks the API contract. A cyclic chain is malformed input, and AMD's runtime walks the same chains when a call is forwarded to it. No working game or host sends one.

To do

At the top of CreateContext, walk the chain once with a bound of 64 (the existing limit) and return FFX_API_RETURN_ERROR_PARAMETER if it is exceeded. CreateUpscale then only sees chains that passed.

Test

CPU. Build a two-node chain that points back to itself, call fe->CreateContext, and expect ERROR_PARAMETER. Without the change the test hangs, so the runner's timeout catches it.

2. Query and configure log lines are not thinned with log_dispatches = 1

What happens

log_dispatches is documented to thin dispatch lines to one in 600 above the log size limit (clean/fsr/src/config.h:113, clean/fsr/README.md:124). ShouldLogDispatch (frontend.cpp:446) does that. Query (:1445) and Configure (:1195) use seen < 3 || config_.logDispatches instead and never thin. A game that queries the jitter every frame keeps writing about two lines per frame after the log passes log_max_mb. The text log is only moved aside when it is opened, above 8 MiB (clean/fsr/src/log_win.h:137).

When it can happen

Only with log_dispatches = 1, a diagnostic setting that is off by default, over a long session. With the default only the first 3 calls of each type are logged.

To do

In both places, use seen < 3 || (config_.logDispatches && ShouldLogDispatch(seen)). Failed calls are still always logged. A live size cap for the text log is optional; if added, it has to coordinate with the writer's write_mutex_.

Test

CPU. Give the front end a stand-in platform_.logBytes that returns more than log_max_mb, set log_dispatches = 1, run 1200 jitter queries, and check that the log holds about 2 query lines, not 1200.

Lingua principale
C++
Stelle
12
Fork
2
Merge medio
3h 10m
PR unite (30g)
171

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di phantoslayer21/wronggpu

Tutte le issue di phantoslayer21/wronggpu

Issue simili

Altre issue su C++

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.