Front end hardening: bound the descriptor-chain walk, thin query and configure log lines

Ouverte
#61 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
64/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
cpp

Piste de recherche

Start in clean/fsr/src/frontend.cpp: the pNext walk in CreateContext (~line 460) and CreateUpscale (~533), and the logging in Query (~1445) and Configure (~1195), which should use ShouldLogDispatch (~446). Read config.h:113 and log_win.h:137 for the log_dispatches and size rules. Done when a self-referencing chain returns FFX_API_RETURN_ERROR_PARAMETER in a CPU test, and 1200 jitter queries with log_dispatches=1 leave about 2 query lines.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

area: front-end enhancement

Two small, independent changes in clean/fsr/src/frontend.cpp. Found by reading the code; neither has been reproduced.

1. The descriptor-chain walk is not bounded

What happens

The walk over the pNext chain in CreateContext (:460) has no bound, and neither has the walk in CreateUpscale (:533). A chain that points back to itself would hang the calling thread. DescribeChain (clean/fsr/src/ffx_describe.cpp:337) stops at 16 nodes and CreateAmdWithoutPrivateVersion (frontend.cpp:192) stops at 64.

When it can happen

Only for a caller that breaks the API contract. A cyclic chain is malformed input, and AMD's runtime walks the same chains when a call is forwarded to it. No working game or host sends one.

To do

At the top of CreateContext, walk the chain once with a bound of 64 (the existing limit) and return FFX_API_RETURN_ERROR_PARAMETER if it is exceeded. CreateUpscale then only sees chains that passed.

Test

CPU. Build a two-node chain that points back to itself, call fe->CreateContext, and expect ERROR_PARAMETER. Without the change the test hangs, so the runner's timeout catches it.

2. Query and configure log lines are not thinned with log_dispatches = 1

What happens

log_dispatches is documented to thin dispatch lines to one in 600 above the log size limit (clean/fsr/src/config.h:113, clean/fsr/README.md:124). ShouldLogDispatch (frontend.cpp:446) does that. Query (:1445) and Configure (:1195) use seen < 3 || config_.logDispatches instead and never thin. A game that queries the jitter every frame keeps writing about two lines per frame after the log passes log_max_mb. The text log is only moved aside when it is opened, above 8 MiB (clean/fsr/src/log_win.h:137).

When it can happen

Only with log_dispatches = 1, a diagnostic setting that is off by default, over a long session. With the default only the first 3 calls of each type are logged.

To do

In both places, use seen < 3 || (config_.logDispatches && ShouldLogDispatch(seen)). Failed calls are still always logged. A live size cap for the text log is optional; if added, it has to coordinate with the writer's write_mutex_.

Test

CPU. Give the front end a stand-in platform_.logBytes that returns more than log_max_mb, set log_dispatches = 1, run 1200 jitter queries, and check that the log holds about 2 query lines, not 1200.

Langage dominant
C++
Étoiles
12
Forks
2
Merge moyen
3 h 10 min
PR mergées (30 j)
171

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de phantoslayer21/wronggpu

Toutes les issues de phantoslayer21/wronggpu

Issues similaires

Plus d'issues C++

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.