Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Run a security review: fuzz the loaders, parser and save import, and review the threat model

Aperta
  • Qualcosa non va?
#61 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
25/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
github-actions, json, typescript, yaml
Ambito
backend, security, testing

Direzione di ricerca

Start with SECURITY.md and architecture section 8, then review the listed compiler, loader, parser, save, CSP, terminal, and workflow files. Add bounded fuzz and property-based coverage for the specified inputs, including YAML aliases and oversized input, and run the tests in CI plus a longer manual fuzz run. Done means SECURITY.md records the review and every finding is fixed or filed, with no open crashes.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area: engine area: web priority: high type: chore

Context

Content packs, save files and parser input are untrusted (SECURITY.md). Before v1.0 promises compatibility, the controls need a systematic review. Several controls landed during the v0.1 review: a Content-Security-Policy with Trusted Types in both builds (every end-to-end test fails on a violation), a unit test that apps/web/src uses no HTML or script sink, validation of saved states against their pack and a 5 MB cap on save files, own-property lookups so that ids such as constructor are safe, a per-call work budget in the engine, terminal-safe printing of pack text in the CLI, tested path checks for the files lexvm generate writes, and SHA-pinned actions with read-only tokens. Deep nesting is tested; the YAML alias cap (100) and oversized input are not.

Scope

  • Property-based and fuzz tests (dev dependency): compile and loadPack with random and mutated YAML and JSON (only diagnostics, never crashes; bounded time and memory, including YAML alias expansion, deep nesting and large input); parseCommand with random Unicode; save import with mutated saves; step with random commands on valid packs (no exceptions; state stays plain JSON).
  • Prototype-pollution tests across compile, runtime, saves and the player with ids such as constructor, toString and hasOwnProperty, and with map keys that the id pattern must reject.
  • Player: review the CSP of both builds (a meta tag cannot set frame-ancestors), the service worker scope and cache behaviour, the shared-origin storage risk, and the import checks on the main thread (#22).
  • CLI: confirm that the API key never appears in output or files; review the terminal escaping.
  • Workflows: script injection, permissions and trigger types, especially the v0.3 workflows.
  • A threat model review; update SECURITY.md.

Acceptance criteria

  • Fuzz tests run in CI with a bounded runtime, plus a longer manual run; no open crashes.
  • Alias expansion and oversized input each produce a diagnostic within bounded time (tested), as deep nesting does today.
  • SECURITY.md is updated; every finding is fixed or filed.

References

  • SECURITY.md
  • docs/architecture.md (section 8)
  • packages/engine/src/compile-yaml.ts
  • packages/engine/src/load.ts
  • packages/engine/src/parser.ts
  • apps/web/src/logic/saves.ts
  • apps/web/build/csp.ts
  • packages/cli/src/term.ts
  • packages/cli/src/generate/fenced.ts
  • .github/workflows/
Lingua principale
TypeScript
Stelle
0
Fork
0
Merge medio
28m
PR unite (30g)
2

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di nullthrone/lexvm

Tutte le issue di nullthrone/lexvm

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.