Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Run a security review: fuzz the loaders, parser and save import, and review the threat model

Abierto
  • ¿Algo no está bien?
#61 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
25/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
github-actions, json, typescript, yaml
Área
backend, security, testing

Línea de trabajo

Start with SECURITY.md and architecture section 8, then review the listed compiler, loader, parser, save, CSP, terminal, and workflow files. Add bounded fuzz and property-based coverage for the specified inputs, including YAML aliases and oversized input, and run the tests in CI plus a longer manual fuzz run. Done means SECURITY.md records the review and every finding is fixed or filed, with no open crashes.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area: engine area: web priority: high type: chore

Context

Content packs, save files and parser input are untrusted (SECURITY.md). Before v1.0 promises compatibility, the controls need a systematic review. Several controls landed during the v0.1 review: a Content-Security-Policy with Trusted Types in both builds (every end-to-end test fails on a violation), a unit test that apps/web/src uses no HTML or script sink, validation of saved states against their pack and a 5 MB cap on save files, own-property lookups so that ids such as constructor are safe, a per-call work budget in the engine, terminal-safe printing of pack text in the CLI, tested path checks for the files lexvm generate writes, and SHA-pinned actions with read-only tokens. Deep nesting is tested; the YAML alias cap (100) and oversized input are not.

Scope

  • Property-based and fuzz tests (dev dependency): compile and loadPack with random and mutated YAML and JSON (only diagnostics, never crashes; bounded time and memory, including YAML alias expansion, deep nesting and large input); parseCommand with random Unicode; save import with mutated saves; step with random commands on valid packs (no exceptions; state stays plain JSON).
  • Prototype-pollution tests across compile, runtime, saves and the player with ids such as constructor, toString and hasOwnProperty, and with map keys that the id pattern must reject.
  • Player: review the CSP of both builds (a meta tag cannot set frame-ancestors), the service worker scope and cache behaviour, the shared-origin storage risk, and the import checks on the main thread (#22).
  • CLI: confirm that the API key never appears in output or files; review the terminal escaping.
  • Workflows: script injection, permissions and trigger types, especially the v0.3 workflows.
  • A threat model review; update SECURITY.md.

Acceptance criteria

  • Fuzz tests run in CI with a bounded runtime, plus a longer manual run; no open crashes.
  • Alias expansion and oversized input each produce a diagnostic within bounded time (tested), as deep nesting does today.
  • SECURITY.md is updated; every finding is fixed or filed.

References

  • SECURITY.md
  • docs/architecture.md (section 8)
  • packages/engine/src/compile-yaml.ts
  • packages/engine/src/load.ts
  • packages/engine/src/parser.ts
  • apps/web/src/logic/saves.ts
  • apps/web/build/csp.ts
  • packages/cli/src/term.ts
  • packages/cli/src/generate/fenced.ts
  • .github/workflows/
Lenguaje dominante
TypeScript
Estrellas
0
Forks
0
Merge medio
28 min
PR fusionados (30 d)
2

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de nullthrone/lexvm

Todos los issues de nullthrone/lexvm

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.