Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Show character lines from dialogue option effects as speech

Aperta
  • Qualcosa non va?
#48 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
typescript, yaml
Ambito
backend-api-design, full-stack

Direzione di ricerca

Read CONTRIBUTING.md’s “Changing the content pack format” guidance and docs/spec/content-pack.md sections 9 and 12 first. Then trace the say effect through packages/engine/src/effects.ts and its rendering in apps/web/src/components/transcript.ts; inspect the noir pack’s dialogues.yaml and check the demo pack and authoring guide for similar cases. Choose and implement an option, convert the 17 reactions, bump the pack version, and verify the player rendering and the specified lexvm check results.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area: content area: engine content-pack priority: low type: bug

Context

The player renders the say of a dialogue node (block kind npc) with a speaker bar, but a say effect in an option's do produces a narration block (text). In the noir pack 17 such effects are direct speech, for example Asmussen's »Oben? Da lagert nichts. Und wenn doch, fragen Sie Kröger.« after the option »Ich war oben, Asmussen. Vierter Boden.« (dialogues.yaml). Between two npc blocks the line looks like narration, so it is less clear who is speaking; it showed up on a phone screenshot of Asmussen's interrogation during the v0.1 review. It was left unchanged in v0.1 because the pack YAML was changed only for real bugs.

Options

  • A. Pack only: move each reaction into a node's say and goto back. No format change, but more nodes, and possibly a tap more per reaction.
  • B. Additive format change: a say effect can name a speaker (for example say: { text: "…", npc: asmussen }) and is then rendered as an npc block. Spec, schema, JSON Schema and prompt kit change.
  • C. Engine rule: every say effect run by a dialogue option becomes an npc block. Simple, but wrong for narration in option effects such as »Dann ist sie fort.«

Scope

  • Choose an option here. B is an additive change to lexvm-pack/1 and follows CONTRIBUTING.md (Changing the content pack format).
  • Convert the 17 lines in the noir pack and bump its version, keeping the walkthrough and the lexvm check results.
  • Check the demo pack and the authoring guide for the same pattern.

Acceptance criteria

  • Character reactions in the noir pack's dialogues render in the speaker style in the player.
  • Narration in option effects stays narration.
  • lexvm check for the noir pack still reports no errors, with the same walkthrough and a complete exploration.

References

  • packs/letzte-nacht-der-reichsmark/dialogues.yaml
  • packages/engine/src/effects.ts
  • apps/web/src/components/transcript.ts
  • docs/spec/content-pack.md (sections 9 and 12)
  • CONTRIBUTING.md (Changing the content pack format)
Lingua principale
TypeScript
Stelle
0
Fork
0
Merge medio
28m
PR unite (30g)
2

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di nullthrone/lexvm

Tutte le issue di nullthrone/lexvm

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.