Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Show character lines from dialogue option effects as speech

Abierto
  • ¿Algo no está bien?
#48 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
35/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
typescript, yaml
Área
backend-api-design, full-stack

Línea de trabajo

Read CONTRIBUTING.md’s “Changing the content pack format” guidance and docs/spec/content-pack.md sections 9 and 12 first. Then trace the say effect through packages/engine/src/effects.ts and its rendering in apps/web/src/components/transcript.ts; inspect the noir pack’s dialogues.yaml and check the demo pack and authoring guide for similar cases. Choose and implement an option, convert the 17 reactions, bump the pack version, and verify the player rendering and the specified lexvm check results.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area: content area: engine content-pack priority: low type: bug

Context

The player renders the say of a dialogue node (block kind npc) with a speaker bar, but a say effect in an option's do produces a narration block (text). In the noir pack 17 such effects are direct speech, for example Asmussen's »Oben? Da lagert nichts. Und wenn doch, fragen Sie Kröger.« after the option »Ich war oben, Asmussen. Vierter Boden.« (dialogues.yaml). Between two npc blocks the line looks like narration, so it is less clear who is speaking; it showed up on a phone screenshot of Asmussen's interrogation during the v0.1 review. It was left unchanged in v0.1 because the pack YAML was changed only for real bugs.

Options

  • A. Pack only: move each reaction into a node's say and goto back. No format change, but more nodes, and possibly a tap more per reaction.
  • B. Additive format change: a say effect can name a speaker (for example say: { text: "…", npc: asmussen }) and is then rendered as an npc block. Spec, schema, JSON Schema and prompt kit change.
  • C. Engine rule: every say effect run by a dialogue option becomes an npc block. Simple, but wrong for narration in option effects such as »Dann ist sie fort.«

Scope

  • Choose an option here. B is an additive change to lexvm-pack/1 and follows CONTRIBUTING.md (Changing the content pack format).
  • Convert the 17 lines in the noir pack and bump its version, keeping the walkthrough and the lexvm check results.
  • Check the demo pack and the authoring guide for the same pattern.

Acceptance criteria

  • Character reactions in the noir pack's dialogues render in the speaker style in the player.
  • Narration in option effects stays narration.
  • lexvm check for the noir pack still reports no errors, with the same walkthrough and a complete exploration.

References

  • packs/letzte-nacht-der-reichsmark/dialogues.yaml
  • packages/engine/src/effects.ts
  • apps/web/src/components/transcript.ts
  • docs/spec/content-pack.md (sections 9 and 12)
  • CONTRIBUTING.md (Changing the content pack format)
Lenguaje dominante
TypeScript
Estrellas
0
Forks
0
Merge medio
28 min
PR fusionados (30 d)
2

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de nullthrone/lexvm

Todos los issues de nullthrone/lexvm

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.