Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

server: sessions of failed scenarios are never closed (close() skipped on the error path)

Aperta
  • Qualcosa non va?
#526 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 4 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
76/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
testing-qa

Direzione di ricerca

Start with the connection lifecycle in src/scenarios/server/prompts.ts and resources.ts, then search the server scenarios for the same try/catch pattern. Run npx @modelcontextprotocol/conformance server --url against a server without prompts/list to reproduce the open sessions. Done means failed scenarios close their connections and no longer leave GET streams or sessions open.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Describe the bug

When a server scenario fails, its Streamable HTTP session is never terminated. #79 added the DELETE to the connection's close(), but most scenarios call close() as the last statement of their try block, so it only runs on the success path. When the scenario throws (for example on a -32601 for a method the server does not implement), the catch records the failure and the session, including its GET stream, stays open until the process exits.

For example, on main (7169291), every scenario in src/scenarios/server/prompts.ts and resources.ts follows this shape:

try {
  const conn = await connectToServer(serverUrl);
  // ... checks that can throw ...
  await conn.close();   // skipped when anything above throws
} catch (error) {
  checks.push({ /* FAILURE */ });
}

The same pattern is in 0.2.0-alpha.11: of about 50 close() calls in the bundle, 4 are in a finally.

Why it matters

A server that caps concurrent sessions per client (a reasonable defence for an authenticated HTTP server) fills up after a few failing scenarios, and every later scenario gets HTTP 503 at initialize. Their results then describe the harness, not the server. Running conformance server against a gateway with a cap of 4 sessions per client, the 2025-11-25 run gets 13 of these 503s, and scenarios later in the run cannot be scored. Because the open GET stream is also left in place, the server cannot tell those sessions apart from live, idle clients, so it has no safe way to reclaim them.

Expected behavior

Close the connection on every exit path, e.g.:

let conn: Connection | undefined;
try {
  conn = await connectToServer(serverUrl);
  // ... checks ...
} catch (error) {
  checks.push({ /* FAILURE */ });
} finally {
  await conn?.close().catch(() => {});
}

To Reproduce

  1. Run npx @modelcontextprotocol/conformance server --url <server> against a server that does not implement prompts/list (so the prompts scenarios fail with -32601).
  2. Watch the server: sessions from the failed scenarios receive no DELETE, and their GET streams stay open until the suite exits.

Additional context

Found while running the suite against Fathomgate, an MCP proxy, through its HTTP listener. Happy to send a PR if that helps.

Lingua principale
TypeScript
Stelle
127
Fork
107
Merge medio
2g 22h
PR unite (30g)
5

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di modelcontextprotocol/conformance

Tutte le issue di modelcontextprotocol/conformance

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.