Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

server: sessions of failed scenarios are never closed (close() skipped on the error path)

Abierto
  • ¿Algo no está bien?
#526 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
76/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
typescript
Área
testing-qa

Línea de trabajo

Start with the connection lifecycle in src/scenarios/server/prompts.ts and resources.ts, then search the server scenarios for the same try/catch pattern. Run npx @modelcontextprotocol/conformance server --url against a server without prompts/list to reproduce the open sessions. Done means failed scenarios close their connections and no longer leave GET streams or sessions open.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Describe the bug

When a server scenario fails, its Streamable HTTP session is never terminated. #79 added the DELETE to the connection's close(), but most scenarios call close() as the last statement of their try block, so it only runs on the success path. When the scenario throws (for example on a -32601 for a method the server does not implement), the catch records the failure and the session, including its GET stream, stays open until the process exits.

For example, on main (7169291), every scenario in src/scenarios/server/prompts.ts and resources.ts follows this shape:

try {
  const conn = await connectToServer(serverUrl);
  // ... checks that can throw ...
  await conn.close();   // skipped when anything above throws
} catch (error) {
  checks.push({ /* FAILURE */ });
}

The same pattern is in 0.2.0-alpha.11: of about 50 close() calls in the bundle, 4 are in a finally.

Why it matters

A server that caps concurrent sessions per client (a reasonable defence for an authenticated HTTP server) fills up after a few failing scenarios, and every later scenario gets HTTP 503 at initialize. Their results then describe the harness, not the server. Running conformance server against a gateway with a cap of 4 sessions per client, the 2025-11-25 run gets 13 of these 503s, and scenarios later in the run cannot be scored. Because the open GET stream is also left in place, the server cannot tell those sessions apart from live, idle clients, so it has no safe way to reclaim them.

Expected behavior

Close the connection on every exit path, e.g.:

let conn: Connection | undefined;
try {
  conn = await connectToServer(serverUrl);
  // ... checks ...
} catch (error) {
  checks.push({ /* FAILURE */ });
} finally {
  await conn?.close().catch(() => {});
}

To Reproduce

  1. Run npx @modelcontextprotocol/conformance server --url <server> against a server that does not implement prompts/list (so the prompts scenarios fail with -32601).
  2. Watch the server: sessions from the failed scenarios receive no DELETE, and their GET streams stay open until the suite exits.

Additional context

Found while running the suite against Fathomgate, an MCP proxy, through its HTTP listener. Happy to send a PR if that helps.

Lenguaje dominante
TypeScript
Estrellas
127
Forks
101
Merge medio
4 d 7 h
PR fusionados (30 d)
6

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de modelcontextprotocol/conformance

Todos los issues de modelcontextprotocol/conformance

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.