Inline flags such as `(?i)` in one `-e` pattern leak into the other patterns, and indexed and scanned results disagree
I maintainer di solito rispondono entro 1 giorno
Una pull request collegata è già stata integrata.
- #187 di @shengyfu — integrata
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 76/100
Direzione di ricerca
Start with combine_patterns in tgrep-cli/src/matching.rs and compare how it combines multiple patterns with the per-pattern parsing in build_multi_pattern_plan in tgrep-core/src/query.rs. Add a regression test for the two reported inline-flag queries, comparing scan and indexed results. Done means inline flags affect only their own pattern and indexed, scanned, and serve results agree.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Summary
When several patterns are given with -e (or -f), an inline flag group such as (?i) or (?-i) at the start of one pattern also applies to the patterns after it. ripgrep scopes inline flags to the pattern they appear in.
The index planner parses each pattern on its own, so it and the matcher disagree: the same query can give different results with and without the index.
Reproduce
mkdir repro && cd repro
printf 'bar\n' > bar.txt
tgrep index .
tgrep -i -e '(?-i)foo' -e 'BAR' .
tgrep --no-index -i -e '(?-i)foo' -e 'BAR' .
tgrep -e '(?i)foo' -e 'BAR' .
tgrep --no-index -e '(?i)foo' -e 'BAR' .
| Query | Actual: tgrep (index, serve) |
Actual: tgrep --no-index |
Expected: rg 15.1.0 |
|---|---|---|---|
-i -e '(?-i)foo' -e 'BAR' |
no match (exit 1) | no match (exit 1) | bar.txt:bar |
-e '(?i)foo' -e 'BAR' |
no match (exit 1) | bar.txt:bar |
no match (exit 1) |
- In the first query,
(?-i)fromfooturns-ioff forBARtoo, sobaris missed everywhere. - In the second,
(?i)fromfoomakesBARmatchbarduring a scan. The index plannedBARcase-sensitively and drops the file, so the indexed result differs from the scan.
With -w or -x the queries behave like ripgrep, because each pattern is then wrapped in its own group.
Environment
- tgrep 1.1.0, built from 1120aca (current
main) with rustc 1.95.0 (59807616e 2026-04-14) - Windows 11 Pro (build 28000); the code involved is platform-independent
- The indexed result is the same with a local index and through
tgrep serve
Cause
combine_patterns only wraps a pattern in a group for -w/-x. Otherwise it joins the raw patterns as alternatives of one group:
-e '(?i)foo' -e 'BAR' becomes (?:(?i)foo|BAR). In regex syntax a bare flag group applies until the end of the enclosing group, so it reaches BAR too. build_multi_pattern_plan plans each pattern separately, where the flag does not leak.
Possible fix
Wrap every pattern in its own non-capturing group before joining, for example (?:(?i)foo)|(?:BAR), whether or not -w/-x is set. Flags then stay inside their pattern, which is also how the planner already reads them. The fancy-regex path is built from the same combined string, so it would be covered too.
A regression test could compare both queries above across --no-index, a local index and serve.
- Lingua principale
- Rust
- Stelle
- 3.5k
- Fork
- 139
- Merge medio
- 17h 20m
- PR unite (30g)
- 27
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Nessun modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di microsoft/tgrep
-
Difficoltà 4/5 3-5 giorni Idoneità per principianti 45/100
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di microsoft/tgrep
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
calcit-lang/caps#16 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 85/100
penso/herdr-gpui#934 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
Y-ASLant/ElegantClipboard#178 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
linxiv-dev/linXiv#384 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
priority middle
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
KATO-Hiro/AtCoderClans#12945 ·
I maintainer di solito rispondono entro 1 giorno