Consolidate discovery module ownership and split JSONRPC orchestration responsibilities
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 25/100
Línea de trabajo
Start with the binary module declarations in crates/pet/src/main.rs, the public modules in crates/pet/src/lib.rs, and the orchestration in crates/pet/src/jsonrpc.rs. Review the landing order in #528 and dependencies #536, #539, and #540 before separating responsibilities. Done means behavior, ordering, state-sync semantics, coverage, documentation, formatting, tests, and warnings-as-errors checks remain intact.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Tracking plan: #528
Priority: P3. Evidence: source-confirmed maintainability and duplicate-compilation concern; no runtime speedup is assumed.
Problem
The JSONRPC orchestration module combines handlers, configuration publication/rollback, refresh coordination, locator state transfer, and telemetry follow-up. The binary also declares find/locators modules that are already public modules in the library, creating parallel module instances instead of using one implementation boundary.
Sources: binary module declarations, library modules, JSONRPC orchestration.
Scope
Use the library discovery/locator implementation from both CLI and server entry points. Extract configuration publication and refresh coordination into independently testable components, leaving RPC handlers as thin adapters. Keep locator crates and priority ordering; avoid a workspace-wide crate merger or async rewrite.
Separate behavior changes from code movement so reviewers can verify this is behavior-preserving. Update architecture/state documentation to the final ownership model, including actual transient-versus-persistent cache lifetimes and all current locators such as Hatch. Move tests with their responsibilities without losing coverage or weakening assertions.
Acceptance criteria
- Binary and library no longer compile separate find/locators module instances; public interfaces remain deliberate and minimal.
- Configuration publication, refresh coordination, and handler adaptation have distinct, directly testable responsibilities.
- Existing CLI/JSONRPC output, error behavior, locator order, coalescing, generation checks, and state-sync semantics remain unchanged.
- Full default-feature tests, relevant feature/platform jobs, formatting, and warnings-as-errors lint pass.
- #531/#533 performance and #534 production coverage do not regress; no unmeasured runtime-speedup claim is used to justify the refactor.
- Documentation reflects the implementation and the change does not introduce generic abstractions used only once.
Dependencies
Perform after #536, bounded scheduling #539, and output ownership #540 stabilize; the complete landing order is in #528. Use #534 coverage and #531/#533 measurements as guardrails. Smaller purely mechanical library-module reuse can be split out earlier if isolated and separately reviewed.
- Lenguaje dominante
- Rust
- Estrellas
- 207
- Forks
- 45
- Merge medio
- 8 h 19 min
- PR fusionados (30 d)
- 2
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de microsoft/python-environment-tools
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
microsoft/python-environment-tools#525 · 1 comentario ·
-
enhancement
Dificultad 5/5 Más de una semana Aptitud para principiantes 35/100
-
enhancement
Dificultad 5/5 Más de una semana Aptitud para principiantes 35/100
-
debt
Dificultad 5/5 Más de una semana Aptitud para principiantes 35/100
-
enhancement
Dificultad 5/5 Más de una semana Aptitud para principiantes 35/100
Todos los issues de microsoft/python-environment-tools
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
Eynzof/Hermes-CN-Desktop#616 ·
-
bug rules
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
-
app bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
IronCoreLabs/ironcore-alloy#346 ·
-
good first issue
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100