Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

BUG TokenBijectionConverter cannot represent a literal hyphen, so "e-mail" encodes identically to "email" and decodes without the hyphen

Chiusa
  • Qualcosa non va?
#3,128 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

@kushaltalati ci sta già lavorando.

Dal 11/10/2026.

  • #3129 di @kushaltalati — aperta

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
52/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
python
Ambito
backend

Direzione di ricerca

Start with pyrit/converter/bijection_converter.py and inspect TokenBijectionConverter's encoding, decoding pattern, and teaching instructions. Run the reproduction with the provided mapping, then check the converter tests under tests/unit/converter. Done means literal hyphens round-trip and e-mail encodes differently from email; the issue author says they already have a fix and regression tests ready to submit.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Describe the bug

TokenBijectionConverter (pyrit/converter/bijection_converter.py) joins the code words of one plaintext word with - (_TOKEN_DELIMITER), and encode() passes every unmapped character through unchanged. A hyphen in the plaintext is therefore emitted as the same character as the delimiter, and lands between two code-word runs exactly where an inserted delimiter would. decode()'s pattern (\b(tok)(?:-(tok))*\b) consumes it as a delimiter, so the hyphen disappears:

plaintext encoded (mapping x -> xxx) decoded
email eee-mmm-aaa-iii-lll email
e-mail eee-mmm-aaa-iii-lll email
self-harm sss-eee-lll-fff-hhh-aaa-rrr-mmm selfharm

The class docstring says the delimiter is there "to keep them legible and unambiguously decodable", and the teaching instructions tell the target to "join adjacent code words with hyphens", which leaves the model no way to write a literal hyphen either. So the prompt sent to the target loses hyphens on the way in ("self-harm" becomes "selfharm" once decoded), and any hyphen in the target's answer is lost on the way back.

This is the same collision class that has already been fixed twice in this file: #2696 (literal apostrophes vs. _CASE_MARKER) and #2741 (literal digits vs. digit tokens) in DigitBijectionConverter. The hyphen case in TokenBijectionConverter was not covered.

Steps/Code to Reproduce
import string
from pyrit.converter import TokenBijectionConverter

mapping = {c: c * 3 for c in string.ascii_lowercase}  # explicit mapping, no tokenizer needed
conv = TokenBijectionConverter(tokenizer=None, mapping=mapping)
for text in ("e-mail", "email", "self-harm"):
    enc = conv.encode(prompt=text)
    print(text, "->", enc, "->", conv.decode(enc))
Expected Results

Each input round-trips, and e-mail does not encode to the same text as email.

e-mail -> eee--mmm-aaa-iii-lll -> e-mail
email -> eee-mmm-aaa-iii-lll -> email
self-harm -> sss-eee-lll-fff--hhh-aaa-rrr-mmm -> self-harm
Actual Results
e-mail -> eee-mmm-aaa-iii-lll -> email
email -> eee-mmm-aaa-iii-lll -> email
self-harm -> sss-eee-lll-fff-hhh-aaa-rrr-mmm -> selfharm

Hyphens that are not directly between two letters (a - b, -lead, trail-) happen to survive because the decode pattern requires a code word on both sides, so the loss is specific to hyphenated words, which is the common case.

Suggested fix

Escape a literal hyphen as a doubled delimiter (--) on encode, the same way DigitBijectionConverter doubles a literal apostrophe or tilde, and have the decode pattern match -- first and restore it to one hyphen. A doubled delimiter can never be produced by joining code words, so it is unambiguous. The teaching instructions should tell the target to write a literal hyphen as two hyphens.

I have the fix with regression tests ready and can open the PR. The new round-trip cases fail on main (6 failed) and pass with the change; tests/unit/converter passes in full.

Versions
  • OS: macOS 26.5
  • Python version: 3.14.8
  • PyRIT version: 1.2.0.dev0, installed from main (0a5abbf9) in editable mode
Lingua principale
Python
Stelle
4.6k
Fork
944
Merge medio
2g 17h
PR unite (30g)
328

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

  • Nessun Dockerfile né file Docker Compose
  • Ha un modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di microsoft/PyRIT

Tutte le issue di microsoft/PyRIT

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.