Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

work-items: preflight credits the main checkout's settings.local.json to worktrees on Windows, where approvals stay per worktree

Aperta
  • Qualcosa non va?
#7,290 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
72/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
shell
Ambito
tooling

Direzione di ricerca

Read plugins/work-items/skills/work/scripts/preflight.sh and its collect() function, then compare the platform-specific settings behavior described in the issue with Cases 16 and 16b in plugins/work-items/skills/work/scripts/preflight.test.sh. Add a Windows-layout test alongside those cases and update the preflight behavior to match it. Done means the main settings file is not credited for a Windows worktree and the worktree's own local settings are considered.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

priority: low

Summary

The work-items preflight credits the main checkout's .claude/settings.local.json to every linked worktree. The live docs say approvals are shared that way only where Claude Code uses the repository root; on Windows and the other layouts where it does not, an approval stays with the worktree it was granted in. On those layouts the preflight reports a grant as covered that the worktree session will not have, so an unattended lane can hit a permission prompt the preflight said was covered.

Affected area / component

plugins/work-items/skills/work/scripts/preflight.sh (collect()), plugins/work-items/skills/work/scripts/preflight.test.sh

Steps to reproduce

  1. On Windows, put Bash(gh pr create *) in the main checkout's .claude/settings.local.json only.
  2. Run the preflight for a linked worktree (--worktree-root <worktree>).
  3. The preflight reports no gap for gh pr create.
  4. Start a session in that worktree and run gh pr create: it prompts.

(Steps 1-3 match the existing test "Case 16" at preflight.test.sh:303; step 4 follows from the docs and was not run.)

Expected behavior

On Windows and other layouts where Claude Code does not use the repository root, the preflight reads the worktree's own settings.local.json and does not credit the main checkout's.

Actual behavior

  • preflight.sh:24-31 and :143-146: since Claude Code v2.1.211, "don't ask again" approvals "save here (resolved through worktrees to the main checkout) and apply in every worktree of the repository, so this file is read in every mode". collect() at :343 reads it unconditionally on every platform.
  • preflight.test.sh:303-322 ("Case 16") asserts the main checkout's grant covers a worktree run; :324 ("Case 16b") asserts a worktree's own local file is excluded.
  • Live docs (read 2026-10-12):

Suggested fix

Branch on the layout: on Windows and the other non-repository-root cases listed at https://code.claude.com/docs/en/settings#where-claude-code-keeps-the-local-file-in-a-git-repository (outside a git repository, a home-directory repository root, Windows, or a root not owned by the user), read the worktree's own settings.local.json instead of the main checkout's. Add a Windows-layout case beside Case 16 and invert Case 16b for that layout.

Environment

Windows; work-items on main as of 2026-10-12.

Found during the upstream-pointer sweep (PRs #7061-#7274).

Lingua principale
Shell
Stelle
22
Fork
2
Merge medio
8h 27m
PR unite (30g)
957

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di melodic-software/claude-code-plugins

Tutte le issue di melodic-software/claude-code-plugins

Issue simili

Altre issue su Shell/Bash

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.