Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Compatibility issue with Hof Bergmann map (setMotorProperties error)

Aperta
  • Qualcosa non va?
#241 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
56/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
lua
Ambito
game-dev

Direzione di ricerca

Start with ADS_VehiclePerformance.lua and trace refreshMotorPerformance through reconcileEffectLifecycle to the call that updates motor properties. Reproduce the load on Hof Bergmann and inspect the Relaxing Station and Silo Conveyor XML files named in the report. Done when loading those objects no longer raises the nil motorizedNode error while other ADS systems remain available.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Hello,

While testing the latest ADS version 0.10.0.7 with Farming Simulator 25 v1.25.0.0, I encountered two Lua errors when loading the Hof Bergmann map (v1.4.5.0).

I performed several tests to isolate the problem:

ADS on a base-game map: No setMotorProperties errors.

ADS on Hof Bergmann with its required mods: Two setMotorProperties errors during loading.

ADS on Hof Bergmann without optional LSFM mods: The errors still occur.

After adding temporary diagnostic logging to ADS_VehiclePerformance.lua, we identified the two objects responsible.

  1. Relaxing Station

vehicles/mapVehicles/relaxingStation/relaxingStation.xml
type=FS25_HofBergmann.mapVehicleRelaxingStation
motorizedNode=nil
motor=true

  1. Silo Conveyor

vehicles/mapVehicles/siloConveyor/siloConveyor.xml
type=FS25_HofBergmann.siloConveyor
motorizedNode=nil
motor=true

Both objects have a motor object, but no valid motorizedNode.

The errors occur when ADS attempts to recalculate motor performance through the following call chain:

ADS_Specialization.onPostLoad
→ ADS_VehiclePerformance.reconcileEffectLifecycle
→ ADS_VehiclePerformance.refreshMotorPerformance
→ Motorized.updateMotorProperties
→ setMotorProperties

The game reports:

Script error: 'setMotorProperties':
Argument 1 has wrong type.
Expected: Int. Actual: Nil

Possible cause

Hof Bergmann contains specialized map equipment that uses the Motorized specialization without a conventional physics motor node.

ADS appears to detect these objects as motorized vehicles and attempts to modify their motor properties, even though motorizedNode is nil.

Suggested solution

It may be worth adding a validation check before updating physical motor properties.

If a vehicle has no valid motorizedNode, ADS could skip only the physical motor-performance recalculation while preserving its other systems.

This would potentially improve compatibility with specialized equipment on other mod maps as well.

I am attaching the diagnostic game log containing both identified objects and the corresponding errors.

Additional observation

The log also contains this separate registry error:

[ADS_VEHICLE_PERFORMANCE] Registry error:
condition 'CAB_CLIMATE_UNDERVOLTAGE'
effect 'ELECTRICAL_CONSUMER_LOAD_MODIFIER'
targets unknown electrical consumer 'CAB'

This error appears during ADS initialization, before the map itself is loaded, and may be unrelated to Hof Bergmann.

I hope these findings are useful. Thank you for your continued work on ADS and all the new improvements!

Best regards,
dj-ocas
Czechoslovak 1989's Farming

log.txt

Lingua principale
Lua
Stelle
282
Fork
17
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di id577/FS25_AdvancedDamageSystem

Tutte le issue di id577/FS25_AdvancedDamageSystem

Issue simili

Altre issue su Lua

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.