Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Compatibility issue with Hof Bergmann map (setMotorProperties error)

Abierto
#241 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
56/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
lua
Área
game-dev

Línea de trabajo

Start with ADS_VehiclePerformance.lua and trace refreshMotorPerformance through reconcileEffectLifecycle to the call that updates motor properties. Reproduce the load on Hof Bergmann and inspect the Relaxing Station and Silo Conveyor XML files named in the report. Done when loading those objects no longer raises the nil motorizedNode error while other ADS systems remain available.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Hello,

While testing the latest ADS version 0.10.0.7 with Farming Simulator 25 v1.25.0.0, I encountered two Lua errors when loading the Hof Bergmann map (v1.4.5.0).

I performed several tests to isolate the problem:

ADS on a base-game map: No setMotorProperties errors.

ADS on Hof Bergmann with its required mods: Two setMotorProperties errors during loading.

ADS on Hof Bergmann without optional LSFM mods: The errors still occur.

After adding temporary diagnostic logging to ADS_VehiclePerformance.lua, we identified the two objects responsible.

  1. Relaxing Station

vehicles/mapVehicles/relaxingStation/relaxingStation.xml
type=FS25_HofBergmann.mapVehicleRelaxingStation
motorizedNode=nil
motor=true

  1. Silo Conveyor

vehicles/mapVehicles/siloConveyor/siloConveyor.xml
type=FS25_HofBergmann.siloConveyor
motorizedNode=nil
motor=true

Both objects have a motor object, but no valid motorizedNode.

The errors occur when ADS attempts to recalculate motor performance through the following call chain:

ADS_Specialization.onPostLoad
→ ADS_VehiclePerformance.reconcileEffectLifecycle
→ ADS_VehiclePerformance.refreshMotorPerformance
→ Motorized.updateMotorProperties
→ setMotorProperties

The game reports:

Script error: 'setMotorProperties':
Argument 1 has wrong type.
Expected: Int. Actual: Nil

Possible cause

Hof Bergmann contains specialized map equipment that uses the Motorized specialization without a conventional physics motor node.

ADS appears to detect these objects as motorized vehicles and attempts to modify their motor properties, even though motorizedNode is nil.

Suggested solution

It may be worth adding a validation check before updating physical motor properties.

If a vehicle has no valid motorizedNode, ADS could skip only the physical motor-performance recalculation while preserving its other systems.

This would potentially improve compatibility with specialized equipment on other mod maps as well.

I am attaching the diagnostic game log containing both identified objects and the corresponding errors.

Additional observation

The log also contains this separate registry error:

[ADS_VEHICLE_PERFORMANCE] Registry error:
condition 'CAB_CLIMATE_UNDERVOLTAGE'
effect 'ELECTRICAL_CONSUMER_LOAD_MODIFIER'
targets unknown electrical consumer 'CAB'

This error appears during ADS initialization, before the map itself is loaded, and may be unrelated to Hof Bergmann.

I hope these findings are useful. Thank you for your continued work on ADS and all the new improvements!

Best regards,
dj-ocas
Czechoslovak 1989's Farming

log.txt

Lenguaje dominante
Lua
Estrellas
282
Forks
17
Métricas de merge de PR
Sin PR fusionados en 30 d

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de id577/FS25_AdvancedDamageSystem

Todos los issues de id577/FS25_AdvancedDamageSystem

Issues similares

Más issues de Lua

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.