Move agents/skills -> .agents/skills (post-release; resolve the bench-branch divergence with it)

Aperta
  • Qualcosa non va?
#1,925 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
35/100
Tipo di issue
Refactoring
Chiarezza
Specificata chiaramente
Stato di attività
Ferma
Stack tecnologico
python
Ambito
tooling

Direzione di ricerca

Read AGENTS.md, CLAUDE.md, the self-references in review/SKILL.md and plan/SKILL.md, and compare the skill copies on master and bench/gfql-pokec-polars-lanes. The issue says the bench branch’s +52-line review-protocol edit has already landed via #1924; reconcile the copies, update the documented paths, and verify a fresh clone exposes skills to Codex and Claude Code without manual steps.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Owner decision: .agents/skills/ is the universal convention and pygraphistry should adopt it. Post-release — PRs stay on the current agents/ layout until the GFQL stack lands.

Current state (measured)

  • master tracks agents/skills/ — 3 SKILL.md files.
  • bench/gfql-pokec-polars-lanes tracks .agents/skills/ and has no agents/. The rename happened in 02fc3d1b1, an unrelated benchmark commit — an accidental divergence, not a deliberate migration. It will conflict or double-apply if that branch merges, so fold it into this work rather than letting a bench commit define the repo layout.
  • CLAUDE.md currently documents the opposite of the target ("Canonical repo skills are in agents/skills/", plus a ln -s agents .agents step).

Blast radius: small — 8 references in 4 files

AGENTS.md, CLAUDE.md, and self-references inside the skills (review/SKILL.md ×3, plan/SKILL.md ×1), e.g. agents/skills/review/SKILL.md#vectorization--engine-compatibility. Those in-document anchors are the easy miss because they still read correctly after a rename. No CI or bin/ script references the path, so this cannot break a lane — only documentation links.

Plan (single PR)

  1. git mv agents .agents as one rename-only commit so --find-renames keeps history legible.
  2. Fix the 8 references; then git grep agents/skills must return zero hits that are not .agents/skills.
  3. Rewrite CLAUDE.md's "Skill path conventions" block: .agents/skills/ canonical, keep the .claude/skills symlink step for Claude Code, drop the now-circular ln -s agents .agents.
  4. Reconcile the bench branch: diff the two copies and fold in anything it added (it currently carries a +52-line review-protocol edit that was applied there by mistake and has since been landed on master properly via #1924).
  5. Verify a fresh clone gives both Codex and Claude Code a working skills path with no undocumented manual step.

Why not now

A tree-wide rename conflicts with every open branch touching those files. ~15 stacked PRs are open and #1924 is pending against agents/skills/review/SKILL.md; renaming first would force a rebase for zero benefit.

Lingua principale
Python
Stelle
2.6k
Fork
229
Merge medio
1g 5h
PR unite (30g)
99

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di graphistry/pygraphistry

Tutte le issue di graphistry/pygraphistry

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.