Limit body size for all requests
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 50/100
Direzione di ricerca
Inizia da UpdateConfig in api/plugin.go e traccia la gestione delle richieste attraverso router/router.go; esamina anche api/user.go, auth/authentication.go e plugin/manager.go per i percorsi di accesso interessati. Esegui i test pertinenti del server e considera il lavoro completato quando le richieste, incluse quelle verso /message e /plugin/{id}/config, applicano un limite predefinito configurabile per il body senza rifiutare payload validi.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
We should limit the body size for all requests. It's currently possible to send big messages to /message or big yaml configs to /plugin/{id}/config.
I guess a good default could be something like 10MB, but it should be configurable.
Email Report
Summary
Gotify Server's plugin configuration update feature accepts
attacker-controlled YAML bodies at POST /plugin/{id}/config.
Confirmed in v2.9.1, when registration=true and at least one
installed plugin supports Configurer, an unauthenticated remote
attacker can self-register and submit an oversized configuration body to
trigger severe memory pressure and persistent configuration storage
growth.
Details
UpdateConfig verifies plugin ownership and Configurer support, but
then immediately calls io.ReadAll(ctx.Request.Body) with no size
limit. The full request body is buffered before YAML parsing or
plugin-side validation, so any reachable caller can force memory
allocation proportional to the submitted body size. After validation,
the handler stores the original bytes in conf.Config, which turns the
same endpoint into a persistence amplifier rather than only a transient
parse-time sink.
conf, err := c.DB.GetPluginConfByID(id)
...
if aborted := supportOrAbort(ctx, instance, compat.Configurer); aborted { return }
newconfBytes, err := io.ReadAll(ctx.Request.Body)
...
if err := yaml.Unmarshal(newconfBytes, newConf); err != nil { ... }
if err := instance.ValidateAndSetConfig(newConf); err != nil { ... }
conf.Config = newconfBytes
When registration=true, POST /user is reachable under
authentication.Optional() and allows unauthenticated non-admin
account creation. User creation triggers fireUserAdded, which
initializes per-user instances for all installed plugins, and
RequireClient accepts Basic Auth directly. The attacker can then call
GET /plugin to enumerate a plugin instance whose capabilities
include configurer, fetch the current YAML from
GET /plugin/{id}/config, and reuse that id against
POST /plugin/{id}/config.
Because the handler stores raw YAML bytes rather than a normalized
representation, the attacker can append large YAML comment blocks to an
otherwise valid configuration. yaml.Unmarshal ignores comments, but
the oversized original document is still persisted as
PluginConf.Config. I verified the unbounded body read and raw-byte
persistence in api/plugin.go, and the self-registration plus Basic
Auth reachability in api/user.go, router/router.go,
auth/authentication.go, and plugin/manager.go. I did not identify
a fixed version from the current materials.
PoC
-
Ensure the target runs Gotify Server
v2.9.1with
registration=trueand at least one installed plugin whose
/pluginentry listsconfigurerincapabilities. -
Create a normal account:
POST /user
Content-Type: application/json
{"name":"pocuser","pass":"PocPassw0rd!"}
-
Use Basic Auth for that account to call
GET /plugin, select an
entry whosecapabilitiesarray containsconfigurer, then fetch
its current YAML fromGET /plugin/{id}/config. -
Append a large number of YAML comment lines to the returned document
and submit it back:
POST /plugin/{id}/config
Authorization: Basic <base64(pocuser:PocPassw0rd!)>
Content-Type: application/x-yaml
<original valid YAML>
# padding 000001
# padding 000002
...
- Observe high memory pressure during the request. If the YAML remains
otherwise valid, a subsequentGET /plugin/{id}/configreturns the
enlarged document, confirming that the oversized raw body was
persisted.
Impact
Observed impact is a conditional unauthenticated network denial of
service in deployments that allow self-registration and have at least
one installed Configurer plugin: a remote attacker can consume
process memory with a single oversized request and can repeatedly
enlarge persisted plugin configuration data. Where registration is
disabled, the same bug remains reachable to a low-privilege
authenticated user. I did not confirm confidentiality or integrity
impact from current evidence.
- Lingua principale
- Go
- Stelle
- 15.9k
- Fork
- 876
- Merge medio
- 2g 10h
- PR unite (30g)
- 4
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di gotify/server
-
a:bug
Difficoltà 4/5 3-5 giorni Idoneità per principianti 48/100
-
a:feature
Difficoltà 3/5 1-2 giorni Idoneità per principianti 68/100
-
a:bug
Difficoltà 3/5 1-2 giorni Idoneità per principianti 68/100
-
Session elevation duration is unbounded, and large values silently overflow to a past timestamp Apertaa:bug
Difficoltà 3/5 1-2 giorni Idoneità per principianti 78/100
-
a:bug
Difficoltà 4/5 3-5 giorni Idoneità per principianti 48/100
Tutte le issue di gotify/server
Issue simili
-
area/dev-productivity area/disaster-recovery area/ipcei kind/enhancement
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 85/100
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
-
kind/bug status/0-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
-
🤔 refinement needed
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
equinor/radix-operator#1979 ·