Limit body size for all requests
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 50/100
Línea de trabajo
Comienza con UpdateConfig en api/plugin.go y sigue el procesamiento de las solicitudes a través de router/router.go; revisa también api/user.go, auth/authentication.go y plugin/manager.go para identificar las rutas de acceso afectadas. Ejecuta las pruebas relevantes del servidor y considera terminado el trabajo cuando las solicitudes, incluidas /message y /plugin/{id}/config, apliquen un límite de cuerpo predeterminado configurable sin rechazar payloads válidos.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
We should limit the body size for all requests. It's currently possible to send big messages to /message or big yaml configs to /plugin/{id}/config.
I guess a good default could be something like 10MB, but it should be configurable.
Email Report
Summary
Gotify Server's plugin configuration update feature accepts
attacker-controlled YAML bodies at POST /plugin/{id}/config.
Confirmed in v2.9.1, when registration=true and at least one
installed plugin supports Configurer, an unauthenticated remote
attacker can self-register and submit an oversized configuration body to
trigger severe memory pressure and persistent configuration storage
growth.
Details
UpdateConfig verifies plugin ownership and Configurer support, but
then immediately calls io.ReadAll(ctx.Request.Body) with no size
limit. The full request body is buffered before YAML parsing or
plugin-side validation, so any reachable caller can force memory
allocation proportional to the submitted body size. After validation,
the handler stores the original bytes in conf.Config, which turns the
same endpoint into a persistence amplifier rather than only a transient
parse-time sink.
conf, err := c.DB.GetPluginConfByID(id)
...
if aborted := supportOrAbort(ctx, instance, compat.Configurer); aborted { return }
newconfBytes, err := io.ReadAll(ctx.Request.Body)
...
if err := yaml.Unmarshal(newconfBytes, newConf); err != nil { ... }
if err := instance.ValidateAndSetConfig(newConf); err != nil { ... }
conf.Config = newconfBytes
When registration=true, POST /user is reachable under
authentication.Optional() and allows unauthenticated non-admin
account creation. User creation triggers fireUserAdded, which
initializes per-user instances for all installed plugins, and
RequireClient accepts Basic Auth directly. The attacker can then call
GET /plugin to enumerate a plugin instance whose capabilities
include configurer, fetch the current YAML from
GET /plugin/{id}/config, and reuse that id against
POST /plugin/{id}/config.
Because the handler stores raw YAML bytes rather than a normalized
representation, the attacker can append large YAML comment blocks to an
otherwise valid configuration. yaml.Unmarshal ignores comments, but
the oversized original document is still persisted as
PluginConf.Config. I verified the unbounded body read and raw-byte
persistence in api/plugin.go, and the self-registration plus Basic
Auth reachability in api/user.go, router/router.go,
auth/authentication.go, and plugin/manager.go. I did not identify
a fixed version from the current materials.
PoC
-
Ensure the target runs Gotify Server
v2.9.1with
registration=trueand at least one installed plugin whose
/pluginentry listsconfigurerincapabilities. -
Create a normal account:
POST /user
Content-Type: application/json
{"name":"pocuser","pass":"PocPassw0rd!"}
-
Use Basic Auth for that account to call
GET /plugin, select an
entry whosecapabilitiesarray containsconfigurer, then fetch
its current YAML fromGET /plugin/{id}/config. -
Append a large number of YAML comment lines to the returned document
and submit it back:
POST /plugin/{id}/config
Authorization: Basic <base64(pocuser:PocPassw0rd!)>
Content-Type: application/x-yaml
<original valid YAML>
# padding 000001
# padding 000002
...
- Observe high memory pressure during the request. If the YAML remains
otherwise valid, a subsequentGET /plugin/{id}/configreturns the
enlarged document, confirming that the oversized raw body was
persisted.
Impact
Observed impact is a conditional unauthenticated network denial of
service in deployments that allow self-registration and have at least
one installed Configurer plugin: a remote attacker can consume
process memory with a single oversized request and can repeatedly
enlarge persisted plugin configuration data. Where registration is
disabled, the same bug remains reachable to a low-privilege
authenticated user. I did not confirm confidentiality or integrity
impact from current evidence.
- Lenguaje dominante
- Go
- Estrellas
- 16k
- Forks
- 878
- Merge medio
- 2 d 10 h
- PR fusionados (30 d)
- 4
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de gotify/server
-
a:bug
Dificultad 4/5 3-5 días Aptitud para principiantes 48/100
-
a:feature
Dificultad 3/5 1-2 días Aptitud para principiantes 68/100
-
a:bug
Dificultad 3/5 1-2 días Aptitud para principiantes 68/100
-
Session elevation duration is unbounded, and large values silently overflow to a past timestamp Abiertoa:bug
Dificultad 3/5 1-2 días Aptitud para principiantes 78/100
-
a:bug
Dificultad 4/5 3-5 días Aptitud para principiantes 48/100
Todos los issues de gotify/server
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
-
acceptance-tests phase-coding schema-coverage testing triaged
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100