[self-care:reactive-ui] Sync reactive-ui skill with reactive.js and style composition

Chiusa
  • Qualcosa non va?
#19,644 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
1/5
Tempo stimato
1-3 ore
Idoneità per principianti
15/100
Tipo di issue
Documentazione
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
javascript
Ambito
documentation

Direzione di ricerca

Read .github/skills/reactive-ui/SKILL.md and compare its guidance with dashboard/site/src/reactive.js, styles-notifications.js, styles-primer.js, styles.js, and notification-service.js. The issue describes the two documentation inaccuracies and says the only change should be to the skill file, with no production JavaScript changes. Done means the skill accurately documents abort-signal support and how notification styles are included.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

agentic-workflows self-care self-care:reactive-ui-expert

[!TIP]
Your pull request is ready to create! 🎉 ✅

Everything is OK—the changes have been pushed to a branch. Please review the protected files, then create the pull request when you are ready.

Create the pull request

The original pull request description is below.

Skill-drift fix only (no production JavaScript). No eligible pure-declarative view-source migration was found: the composed dashboard sources are all produced by the query engine or runtime adapters, and no view-source JS projection module exists.

Preserved behavior: no runtime change; only .github/skills/reactive-ui/SKILL.md is edited.

Changes (evidence):

  • derived(compute, { signal }) in dashboard/site/src/reactive.js accepts an abort signal; the skill only mentioned manual disposal.
  • styles-notifications.js is not composed in styles-primer.js; styles.js minifies it via notificationStylesheet() and notification-service.js injects it. The skill claimed all styles-*.js modules are composed by styles-primer.js.

Validation: dashboard typecheck, lint (incl. corpus validation), and npm test (386 files, 3709 tests) pass; npm run docs:build passes. Root npm test shows 43 failures identical with and without this change (gh aw extension unavailable in the runner).

Control Plane

[!NOTE]
Protected files

This patch modifies protected files, which may affect project dependencies, CI/CD pipelines, or agent behaviour.

Protected files

To route changes like this to a review issue instead of blocking, configure protected-files: fallback-to-issue in your workflow configuration.

Generated by SelfCare / Reactive UI Expert · copilot · auto · ~66 AIC · ⌖ ~1 AIC · ⊞ 15.7K · ◷

  • expires on Oct 30, 2026, 6:52 AM UTC
Lingua principale
JavaScript
Stelle
8
Fork
5
Merge medio
2h 50m
PR unite (30g)
815

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di githubnext/gh-cao

Tutte le issue di githubnext/gh-cao

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.