[self-care:reactive-ui] Sync reactive-ui skill with reactive.js and style composition

Cerrado
  • ¿Algo no está bien?
#19,644 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
1/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
15/100
Tipo de issue
Documentación
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
javascript
Área
documentation

Línea de trabajo

Read .github/skills/reactive-ui/SKILL.md and compare its guidance with dashboard/site/src/reactive.js, styles-notifications.js, styles-primer.js, styles.js, and notification-service.js. The issue describes the two documentation inaccuracies and says the only change should be to the skill file, with no production JavaScript changes. Done means the skill accurately documents abort-signal support and how notification styles are included.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

agentic-workflows self-care self-care:reactive-ui-expert

[!TIP]
Your pull request is ready to create! 🎉 ✅

Everything is OK—the changes have been pushed to a branch. Please review the protected files, then create the pull request when you are ready.

Create the pull request

The original pull request description is below.

Skill-drift fix only (no production JavaScript). No eligible pure-declarative view-source migration was found: the composed dashboard sources are all produced by the query engine or runtime adapters, and no view-source JS projection module exists.

Preserved behavior: no runtime change; only .github/skills/reactive-ui/SKILL.md is edited.

Changes (evidence):

  • derived(compute, { signal }) in dashboard/site/src/reactive.js accepts an abort signal; the skill only mentioned manual disposal.
  • styles-notifications.js is not composed in styles-primer.js; styles.js minifies it via notificationStylesheet() and notification-service.js injects it. The skill claimed all styles-*.js modules are composed by styles-primer.js.

Validation: dashboard typecheck, lint (incl. corpus validation), and npm test (386 files, 3709 tests) pass; npm run docs:build passes. Root npm test shows 43 failures identical with and without this change (gh aw extension unavailable in the runner).

Control Plane

[!NOTE]
Protected files

This patch modifies protected files, which may affect project dependencies, CI/CD pipelines, or agent behaviour.

Protected files

To route changes like this to a review issue instead of blocking, configure protected-files: fallback-to-issue in your workflow configuration.

Generated by SelfCare / Reactive UI Expert · copilot · auto · ~66 AIC · ⌖ ~1 AIC · ⊞ 15.7K · ◷

  • expires on Oct 30, 2026, 6:52 AM UTC
Lenguaje dominante
JavaScript
Estrellas
8
Forks
5
Merge medio
2 h 50 min
PR fusionados (30 d)
815

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de githubnext/gh-cao

Todos los issues de githubnext/gh-cao

Issues similares

Más issues de JavaScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.