Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

[Safe Outputs Conformance] MCE-001: add_comment tool description missing explicit CONSTRAINTS disclosure and "50 link" phrasing

Chiusa Adatta ai principianti
  • Qualcosa non va?
#70,175 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
68/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
github-actions, go, javascript
Ambito
tooling

Direzione di ricerca

Inizia da actions/setup/js/safe_outputs_tools.json e trova la descrizione di add_comment; confrontala con la copia sincronizzata in pkg/workflow/js/safe_outputs_tools.json. Controlla actions/setup/js/generate_safe_outputs_tools.cjs e i test nominati per confermare che la formulazione venga mantenuta durante la generazione e corrisponda alle aspettative. Il lavoro è completato quando entrambe le copie espongono i limiti con CONSTRAINTS e la formulazione letterale 50 link, e il controllo di conformità ha esito positivo.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

automated conformance medium-priority safe-outputs
Conformance Check Failure

Check ID: MCE-001
Severity: MEDIUM
Category: Implementation (Section 8.3 MCE2 — Tool Description Constraint Disclosure)

Problem Description

Per the Safe Outputs specification Section 8.3 (MCE2), the add_comment tool description MUST surface its enforcement constraints (character limit, mention limit, link limit) using recognizable, literal phrasing, and MUST contain an explicit CONSTRAINTS or IMPORTANT ... constraint disclosure block. The conformance checker (scripts/check-safe-outputs-conformance.sh, function check_mce_constraint_disclosure) scans pkg/workflow/js/safe_outputs_tools.json for these literal patterns and two sub-checks fail:

  1. No match for the literal phrase 50 link (case-insensitive).
  2. No match for CONSTRAINTS, IMPORTANT.*constraint, or validation constraint within the add_comment tool entry.
Affected Components

  • Files:

    • actions/setup/js/safe_outputs_tools.json (canonical source of the add_comment tool description)
    • pkg/workflow/js/safe_outputs_tools.json (synced copy embedded for the Go compiler — keep both in sync)
    • actions/setup/js/generate_safe_outputs_tools.cjs (runtime generator that composes the final description with suffixes/notes)
<b>🔍 Current vs Expected Behavior</b>
Current Behavior

The add_comment tool description (around line 525 of pkg/workflow/js/safe_outputs_tools.json) reads:

"...Input is limited to 524288 characters, 10 mentions, and configured max-links URL occurrences (default: 50). Oversized agent content is automatically replaced by notices to fit the complete 65536-character published comment..."

The 50-link default is disclosed, but phrased as "max-links URL occurrences (default: 50)" rather than the literal "50 link(s)" substring the spec checker expects, and there is no CONSTRAINTS: (or equivalent IMPORTANT ... constraint) lead-in labelling this as an enforced constraint block.

Expected Behavior

The description should contain a clearly labelled constraints section using literal, greppable phrasing, e.g.:

"CONSTRAINTS: Input is limited to 524288 characters, 10 mentions, and 50 links (configurable via max-links, default: 50)..."

This keeps the existing semantics identical (524288 chars / 10 mentions / default 50 links) while making the constraint disclosure explicit and literal, satisfying MCE2's requirement that agents reliably discover enforcement limits from the tool description text itself.

Remediation Steps

This task can be assigned to a Copilot coding agent with the following steps:

  1. In actions/setup/js/safe_outputs_tools.json, edit the add_comment tool's description field to prefix the constraint sentence with CONSTRAINTS: and rephrase the link limit using the literal substring 50 link (e.g., "50 links") instead of "(default: 50)" alone, while preserving the existing 524288-character and 10-mention figures.
  2. Apply the equivalent edit to pkg/workflow/js/safe_outputs_tools.json so the embedded Go copy stays byte-identical to the canonical source (check for an existing sync/codegen step before hand-editing both).
  3. Check actions/setup/js/generate_safe_outputs_tools.cjs for any place that appends additional suffixes to the add_comment description (e.g. discussions notes) to confirm the new CONSTRAINTS phrasing survives suffix concatenation.
  4. Update any tests asserting on the exact add_comment description text (e.g. actions/setup/js/generate_safe_outputs_tools.test.cjs, actions/setup/js/safe_outputs_mcp_add_comment_constraints.test.cjs, pkg/workflow/safe_outputs_tools_test.go) to match the new wording.
Verification

After remediation, verify the fix by running:

bash scripts/check-safe-outputs-conformance.sh

The check MCE-001 should pass without errors (no [MEDIUM] MCE-001 lines in the output).

References
  • Safe Outputs Specification: docs/src/content/docs/specs/safe-outputs-specification.md (Section 8.3, MCE2)
  • Conformance Checker: scripts/check-safe-outputs-conformance.sh (check_mce_constraint_disclosure, line ~665)
  • Run ID: 39206249052
  • Date: 2026-10-19

Generated by ✅ Daily Safe Outputs Conformance Checker · claude · agent · 74.2 AIC · ⌖ 0.578 AIC · ⊞ 5.3K · ◷

  • expires on Oct 19, 2026, 9:53 PM UTC-08:00
Lingua principale
Go
Stelle
5.4k
Fork
596
Merge medio
3h 26m
PR unite (30g)
822

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di github/gh-aw

Tutte le issue di github/gh-aw

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.