[Request]: network_info_plus: use ConnectivityManager for getWifiIP and getWifiGatewayIP from Android 7 (N), so ethernet works below Android 12
I maintainer di solito rispondono entro 1 giorno
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- Mezza giornata
- Idoneità per principianti
- 22/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Ferma
- Ambito
- mobile, mobile-dev
Direzione di ricerca
Work is already in open PR #3999; do not start a duplicate. The Android path lives in the network_info_plus plugin: NetworkInfoPlusPlugin.setupChannels() currently constructs ConnectivityManager only from VERSION_CODES.S, and NetworkInfo.getWifiIPAddress() / getGatewayIPAddress() use the same S gate (WifiInfo/dhcpInfo below that). Confirm minSdk 19 still needs the Wi-Fi fallback below N. Done means ethernet IP/gateway work on API 24–30 without crashing getDhcpServerAddress on API 24–29.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Plugin
network_info_plus
Use case
If an Android device below version 12 is on ethernet, the plugin can't find the network:
getWifiIP()gives backnullgetWifiSubmask()gives back an empty stringgetWifiBroadcast()andgetWifiIPv6()don't work eithergetWifiGatewayIP()doesn't give the ethernet gateway
On Android 12 and up it works fine. The Android code uses ConnectivityManager there, and that works for any kind of connection. But it only turns on at Build.VERSION_CODES.S. Below that, the plugin uses WifiInfo and dhcpInfo instead. Those only know about Wi-Fi, so on ethernet they just give back 0.
The thing is, the ConnectivityManager calls are much older than Android 12. getActiveNetwork() is API 23, and the rest are API 21. The only newer one is getDhcpServerAddress(), which the gateway code uses. That one is API 30.
The S check came in with #1151. #420 asks for something similar, but this is just for Android.
Proposal
Turn on the ConnectivityManager code from Android 7 (Build.VERSION_CODES.N, API 24) instead of Android 12. That takes 3 small changes.
1. Get ConnectivityManager from N in NetworkInfoPlusPlugin.setupChannels()
Right now it's only set up on S and above, so it's null on older devices. If you only change the check in NetworkInfo.kt, nothing happens.
var connectivityManager: ConnectivityManager? = null
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
connectivityManager = context.applicationContext.getSystemService(Context.CONNECTIVITY_SERVICE) as ConnectivityManager
}
2. Change the check in NetworkInfo.getWifiIPAddress()
Only the version number changes. The rest stays the same.
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
val linkAddresses =
connectivityManager?.getLinkProperties(connectivityManager.activeNetwork)?.linkAddresses
// ...unchanged
}
3. Get the gateway from the default route in NetworkInfo.getGatewayIPAddress()
You can't just change the version number here. getDhcpServerAddress() needs API 30, so it would crash on API 24 to 29. The default route works from API 21. It's also a bit better on Android 12+, because it gives you the real gateway and not the DHCP server. Those aren't always the same thing.
return if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
val linkProperties =
connectivityManager?.getLinkProperties(connectivityManager.activeNetwork)
val defaultRoute = linkProperties?.routes?.firstOrNull { route -> route.isDefaultRoute }
defaultRoute?.gateway?.hostAddress
} else {
// ...existing dhcpInfo fallback, unchanged
}
Subnet mask, broadcast and IPv6 don't need any changes. They all use the IP from getWifiIPAddress(), so they start working once that does.
The plugin's minSdk is 19, so the old Wi-Fi code still runs on anything below N.
I tried this on ethernet on API 25, 28 and 30, and it works on all of them. Before the change, none of them showed anything. It might work on API 23 (M) too, but I haven't tried that.
- Lingua principale
- Dart
- Stelle
- 1.9k
- Fork
- 1.3k
- Merge medio
- 4g 2h
- PR unite (30g)
- 15
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di fluttercommunity/plus_plugins
-
[Bug]: (share_plus) iOS drops the subject when sharing a uriForse già presa @kaluli123123 l’ha presa 5 giorni fa. Apertabug triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
fluttercommunity/plus_plugins#3994 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
[package_info_plus]: Use Flutter's compile-time build name/number on web instead of version.jsonForse già presa @Ortes l’ha presa 10 giorni fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 25/100
fluttercommunity/plus_plugins#3989 ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement triage
Difficoltà 4/5 3-5 giorni Idoneità per principianti 55/100
fluttercommunity/plus_plugins#3976 · 1 reazione ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 4/5 3-5 giorni Idoneità per principianti 35/100
fluttercommunity/plus_plugins#3974 · 1 reazione ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement triage
Difficoltà 5/5 Più di una settimana Idoneità per principianti 48/100
fluttercommunity/plus_plugins#3973 ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di fluttercommunity/plus_plugins
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
genkit-ai/genkit-dart#637 ·
I maintainer di solito rispondono entro 1 giorno
-
[FR] 新增更新弹窗中的“复制链接”按钮Apertaenhancement
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
bggRGjQaUbCoE/PiliPlus#3235 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
lichess-org/mobile#3830 ·
I maintainer di solito rispondono entro 2 giorni
-
Cupertino UI PackageApertaa.fwe a.tut.tutorial fix.bug from.page-issue p2-medium
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 70/100
I maintainer di solito rispondono entro 1 giorno
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
intel/rohd-wave-viewer#11 ·