[Request]: network_info_plus: use ConnectivityManager for getWifiIP and getWifiGatewayIP from Android 7 (N), so ethernet works below Android 12
Los mantenedores suelen responder en 1 día
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- Medio día
- Aptitud para principiantes
- 22/100
- Tipo de issue
- Error
- Claridad
- Bien especificado
- Estado de actividad
- Estancado
- Área
- mobile, mobile-dev
Línea de trabajo
Work is already in open PR #3999; do not start a duplicate. The Android path lives in the network_info_plus plugin: NetworkInfoPlusPlugin.setupChannels() currently constructs ConnectivityManager only from VERSION_CODES.S, and NetworkInfo.getWifiIPAddress() / getGatewayIPAddress() use the same S gate (WifiInfo/dhcpInfo below that). Confirm minSdk 19 still needs the Wi-Fi fallback below N. Done means ethernet IP/gateway work on API 24–30 without crashing getDhcpServerAddress on API 24–29.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Plugin
network_info_plus
Use case
If an Android device below version 12 is on ethernet, the plugin can't find the network:
getWifiIP()gives backnullgetWifiSubmask()gives back an empty stringgetWifiBroadcast()andgetWifiIPv6()don't work eithergetWifiGatewayIP()doesn't give the ethernet gateway
On Android 12 and up it works fine. The Android code uses ConnectivityManager there, and that works for any kind of connection. But it only turns on at Build.VERSION_CODES.S. Below that, the plugin uses WifiInfo and dhcpInfo instead. Those only know about Wi-Fi, so on ethernet they just give back 0.
The thing is, the ConnectivityManager calls are much older than Android 12. getActiveNetwork() is API 23, and the rest are API 21. The only newer one is getDhcpServerAddress(), which the gateway code uses. That one is API 30.
The S check came in with #1151. #420 asks for something similar, but this is just for Android.
Proposal
Turn on the ConnectivityManager code from Android 7 (Build.VERSION_CODES.N, API 24) instead of Android 12. That takes 3 small changes.
1. Get ConnectivityManager from N in NetworkInfoPlusPlugin.setupChannels()
Right now it's only set up on S and above, so it's null on older devices. If you only change the check in NetworkInfo.kt, nothing happens.
var connectivityManager: ConnectivityManager? = null
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
connectivityManager = context.applicationContext.getSystemService(Context.CONNECTIVITY_SERVICE) as ConnectivityManager
}
2. Change the check in NetworkInfo.getWifiIPAddress()
Only the version number changes. The rest stays the same.
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
val linkAddresses =
connectivityManager?.getLinkProperties(connectivityManager.activeNetwork)?.linkAddresses
// ...unchanged
}
3. Get the gateway from the default route in NetworkInfo.getGatewayIPAddress()
You can't just change the version number here. getDhcpServerAddress() needs API 30, so it would crash on API 24 to 29. The default route works from API 21. It's also a bit better on Android 12+, because it gives you the real gateway and not the DHCP server. Those aren't always the same thing.
return if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
val linkProperties =
connectivityManager?.getLinkProperties(connectivityManager.activeNetwork)
val defaultRoute = linkProperties?.routes?.firstOrNull { route -> route.isDefaultRoute }
defaultRoute?.gateway?.hostAddress
} else {
// ...existing dhcpInfo fallback, unchanged
}
Subnet mask, broadcast and IPv6 don't need any changes. They all use the IP from getWifiIPAddress(), so they start working once that does.
The plugin's minSdk is 19, so the old Wi-Fi code still runs on anything below N.
I tried this on ethernet on API 25, 28 and 30, and it works on all of them. Before the change, none of them showed anything. It might work on API 23 (M) too, but I haven't tried that.
- Lenguaje dominante
- Dart
- Estrellas
- 1.9k
- Forks
- 1.3k
- Merge medio
- 4 d 2 h
- PR fusionados (30 d)
- 15
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de fluttercommunity/plus_plugins
-
[Bug]: (share_plus) iOS drops the subject when sharing a uriPosiblemente ocupada @kaluli123123 la tomó hace 5 días. Abiertobug triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
fluttercommunity/plus_plugins#3994 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
[package_info_plus]: Use Flutter's compile-time build name/number on web instead of version.jsonPosiblemente ocupada @Ortes la tomó hace 10 días. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 25/100
fluttercommunity/plus_plugins#3989 ·
Los mantenedores suelen responder en 1 día
-
enhancement triage
Dificultad 4/5 3-5 días Aptitud para principiantes 55/100
fluttercommunity/plus_plugins#3976 · 1 reacción ·
Los mantenedores suelen responder en 1 día
-
Dificultad 4/5 3-5 días Aptitud para principiantes 35/100
fluttercommunity/plus_plugins#3974 · 1 reacción ·
Los mantenedores suelen responder en 1 día
-
enhancement triage
Dificultad 5/5 Más de una semana Aptitud para principiantes 48/100
fluttercommunity/plus_plugins#3973 ·
Los mantenedores suelen responder en 1 día
Todos los issues de fluttercommunity/plus_plugins
Issues similares
-
bug product: very_good_flutter_plugin
Dificultad 1/5 1-3 horas Aptitud para principiantes 78/100
VeryGoodOpenSource/very_good_templates#654 ·
Los mantenedores suelen responder en 1 día
-
enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 80/100
Los mantenedores suelen responder en 1 día
-
Server never consumes the request body on early-error paths: _sinkIncoming does not resume the paused subscriptionQuizá libre de nuevo Un pull request para esta issue se cerró sin fusionarse. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
-
[BUG][All] VLESS URIs with flow=xtls-rprx-vision-udp443 are silently dropped on subscription importAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
-
enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
simonoppowa/OpenNutriTracker#1336 ·
Los mantenedores suelen responder en 1 día